Restore nncp default #971
Merged
Restore nncp default #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelyatin
requested review from
hjensas
and removed request for
dprince and
cjeanner
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[1] created new parameter for NNCP setup and now it explicitly require INSTALL_NNCP=false to be passed along with NETWORK_ISOLATION=false. restoring the previous behavior by using previous defaults relying on NETWORK_ISOLATION and NETWORK_BGP. [1] openstack-k8s-operators#969
karelyatin
force-pushed
the
nncp_default
branch
from
6fbd6cc to
34b0973
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit a7f183b
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] created new parameter for NNCP setup and now it explicitly require
INSTALL_NNCP=false to be passed along with NETWORK_ISOLATION=false.
restoring the previous behavior by using previous defaults relying
on NETWORK_ISOLATION and NETWORK_BGP.
[1] #969