Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhoso] disable nmstate + nncp #59733

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 10, 2024

No description provided.

@stuggi
Copy link
Contributor Author

stuggi commented Dec 10, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from lewisdenny and viroel December 10, 2024 16:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Dec 10, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-keystone-operator-main-keystone-operator-build-deploy-kuttl

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lewisdenny
Copy link
Contributor

Hi @stuggi , What is the context for this change mate?

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

error: build error: Failed to push image: trying to reuse blob sha256:8afba38a614e150d5cec9d32c41bedfe2fe3cc1a11fbd33c712e10abb9e65de9 at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

Hi @stuggi , What is the context for this change mate?

openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. With this the kuttl test ran again successful on the openstack-operator.

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-keystone-operator-main-keystone-operator-build-deploy-kuttl

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@olliewalsh
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@olliewalsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2024
@olliewalsh
Copy link
Contributor

/test ci/prow/core-valid

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@olliewalsh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build05-dry
/test build06-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-master-step-registry-metadata
pull-ci-openshift-release-master-step-registry-shellcheck
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/test ci/prow/core-valid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor

/test pull-ci-openshift-release-master-core-valid

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@olliewalsh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build05-dry
/test build06-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-master-step-registry-metadata
pull-ci-openshift-release-master-step-registry-shellcheck
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/test pull-ci-openshift-release-master-core-valid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor

/test all

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lewisdenny
Copy link
Contributor

Hi @stuggi , What is the context for this change mate?

openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. With this the kuttl test ran again successful on the openstack-operator.

Thank you @stuggi , can you please add that context to the commit message? After that, as I see you have verified the fix by running the two Kuttl jobs, I can merge the patch.

openstack-k8s-operators/install_yamls#969 changed the way when
to apply NNCPs. As a result NNCPs were created for the kuttl
jobs which is wrong. This sets the env vars to disable nmstate
and nncp creation.

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the disable_install_nncp branch from 1b6bc8a to 37e4bc8 Compare December 11, 2024 10:27
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. With this the kuttl test ran again successful on the openstack-operator.

done

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stuggi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-install_yamls-main-install-yamls-deploy openstack-k8s-operators/install_yamls presubmit Registry content changed
pull-ci-openstack-k8s-operators-install_yamls-18.0-fr1-install-yamls-deploy openstack-k8s-operators/install_yamls presubmit Registry content changed
pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy openstack-k8s-operators/mariadb-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-mariadb-operator-18.0-fr1-mariadb-operator-build-deploy openstack-k8s-operators/mariadb-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-mariadb-operator-main-mariadb-operator-build-deploy-kuttl openstack-k8s-operators/mariadb-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-mariadb-operator-18.0-fr1-mariadb-operator-build-deploy-kuttl openstack-k8s-operators/mariadb-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ovn-operator-main-ovn-operator-build-deploy openstack-k8s-operators/ovn-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ovn-operator-18.0-fr1-ovn-operator-build-deploy openstack-k8s-operators/ovn-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ovn-operator-main-ovn-operator-build-deploy-kuttl openstack-k8s-operators/ovn-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ovn-operator-18.0-fr1-ovn-operator-build-deploy-kuttl openstack-k8s-operators/ovn-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-placement-operator-main-placement-operator-build-deploy openstack-k8s-operators/placement-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-placement-operator-18.0-fr1-placement-operator-build-deploy openstack-k8s-operators/placement-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-placement-operator-main-placement-operator-build-deploy-kuttl openstack-k8s-operators/placement-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-placement-operator-18.0-fr1-placement-operator-build-deploy-kuttl openstack-k8s-operators/placement-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-18.0-fr1-neutron-operator-build-deploy openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy-kuttl openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-18.0-fr1-neutron-operator-build-deploy-kuttl openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy-tempest openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-18.0-fr1-neutron-operator-build-deploy-tempest openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-horizon-operator-main-horizon-operator-build-deploy openstack-k8s-operators/horizon-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-horizon-operator-18.0-fr1-horizon-operator-build-deploy openstack-k8s-operators/horizon-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-horizon-operator-main-horizon-operator-build-deploy-kuttl openstack-k8s-operators/horizon-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-horizon-operator-18.0-fr1-horizon-operator-build-deploy-kuttl openstack-k8s-operators/horizon-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ironic-operator-main-ironic-operator-build-deploy openstack-k8s-operators/ironic-operator presubmit Registry content changed

A total of 94 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

/pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Adding back existing lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@karelyatin
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, lewisdenny, olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor Author

stuggi commented Dec 11, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2024
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@stuggi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 381b5a0 into openshift:master Dec 11, 2024
11 checks passed
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 18, 2024
openstack-k8s-operators/install_yamls#969 changed the way when
to apply NNCPs. As a result NNCPs were created for the kuttl
jobs which is wrong. This sets the env vars to disable nmstate
and nncp creation.

Signed-off-by: Martin Schuppert <[email protected]>
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
openstack-k8s-operators/install_yamls#969 changed the way when
to apply NNCPs. As a result NNCPs were created for the kuttl
jobs which is wrong. This sets the env vars to disable nmstate
and nncp creation.

Signed-off-by: Martin Schuppert <[email protected]>
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
openstack-k8s-operators/install_yamls#969 changed the way when
to apply NNCPs. As a result NNCPs were created for the kuttl
jobs which is wrong. This sets the env vars to disable nmstate
and nncp creation.

Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants