-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhoso] disable nmstate + nncp #59733
[rhoso] disable nmstate + nncp #59733
Conversation
/pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openstack-k8s-operators-keystone-operator-main-keystone-operator-build-deploy-kuttl |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Hi @stuggi , What is the context for this change mate? |
error: build error: Failed to push image: trying to reuse blob sha256:8afba38a614e150d5cec9d32c41bedfe2fe3cc1a11fbd33c712e10abb9e65de9 at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout |
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. With this the kuttl test ran again successful on the openstack-operator. |
/pj-rehearse pull-ci-openstack-k8s-operators-keystone-operator-main-keystone-operator-build-deploy-kuttl |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/pj-rehearse ack |
@olliewalsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/test ci/prow/core-valid |
@olliewalsh: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-ci-openshift-release-master-core-valid |
@olliewalsh: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
/pj-rehearse ack |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Thank you @stuggi , can you please add that context to the commit message? After that, as I see you have verified the fix by running the two Kuttl jobs, I can merge the patch. |
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
1b6bc8a
to
37e4bc8
Compare
done |
[REHEARSALNOTIFIER]
A total of 94 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding back existing lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, lewisdenny, olliewalsh, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@stuggi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@stuggi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
No description provided.