-
Notifications
You must be signed in to change notification settings - Fork 47
Use the same variable name for service related images #534
Conversation
/test dataplane-operator-build-deploy-kuttl |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/8aa78357fda24c289bf6767d4e992da0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 28s |
failed on OpenStackControlPlane CR |
recheck |
/test dataplane-operator-build-deploy-kuttl |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/33cec053d3df4f30b20751c55b5d4b9c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 09m 54s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ea93f16f8e7b43429256a4a03568e675 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 01m 54s |
I proposed similar change in #535 and tested it in https://review.rdoproject.org/r/c/testproject/+/50872 - it seems to be working fine. So LGTM for me and I will abandon my PR. |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cb247035fd704777849af0d85d473608 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006664715 failed in 0s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/87b11bb880704d379623be0b37289a4e ✔️ openstack-k8s-operators-content-provider SUCCESS in 54m 55s |
/test dataplane-operator-build-deploy-kuttl |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e43d4181539d47b0b2ea3a2c63625f96 ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 31s |
recheck |
/test dataplane-operator-build-deploy-kuttl |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/98986893a0a5414184b9c800b5f8dd9d ✔️ openstack-k8s-operators-content-provider SUCCESS in 52m 16s |
recheck |
/test dataplane-operator-build-deploy-kuttl |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, slawqo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fao89 LGTM. what's the path forward for this one? Do we need to push on getting the depends-on (openstack-k8s-operators/openstack-operator#568) merged?
@slagle yes, without openstack-k8s-operators/openstack-operator#568 CI breaks |
retest |
New changes are detected. LGTM label has been removed. |
recheck |
2 similar comments
recheck |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e37d11062bd84e5396cc7fcb36e528bf ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 38m 28s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/45d54895dd214d62b559e0b12690131d ✔️ openstack-k8s-operators-content-provider SUCCESS in 26m 58s |
closing in favor of |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1dee05eb239f482ab6b294055a0d8e0c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 07s |
/retest |
recheck |
Nova: https://github.com/openstack-k8s-operators/nova-operator/blob/main/config/default/manager_default_images.yaml
OVN: https://github.com/openstack-k8s-operators/ovn-operator/blob/main/config/default/manager_default_images.yaml
Depends-On: openstack-k8s-operators/openstack-operator#568