Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Use the same env var for the ovn-controller as set by ovn-operator #535

Closed
wants to merge 1 commit into from

Conversation

slawqo
Copy link
Contributor

@slawqo slawqo commented Nov 22, 2023

This patch renames
"RELATED_IMAGE_OPENSTACK_EDPM_OVN_CONTROLLER_AGENT_DEFAULT_IMG" to the "RELATED_IMAGE_OVN_CONTROLLER_IMAGE_URL_DEFAULT" which is the same as used by the ovn-operator to set ovn-controller image used on the control plane.
OVN requires to use same versions of the ovn-controller and ovn-northd always so using same envVar will make sure that there will be no mismatch there.

Jira: #OSPRH-1504

This patch renames
"RELATED_IMAGE_OPENSTACK_EDPM_OVN_CONTROLLER_AGENT_DEFAULT_IMG" to the
"RELATED_IMAGE_OVN_CONTROLLER_IMAGE_URL_DEFAULT" which is the same as
used by the ovn-operator to set ovn-controller image used on the
control plane.
OVN requires to use same versions of the ovn-controller and ovn-northd
always so using same envVar will make sure that there will be no
mismatch there.

Jira: #OSPRH-1504
Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slawqo
Once this PR has been reviewed and has the lgtm label, please assign rabi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 22, 2023

@slawqo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/dataplane-operator-build-deploy-kuttl 36cef60 link true /test dataplane-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bf911770c04848fcb1341cb7694f0bc1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 23s
podified-multinode-edpm-deployment-crc FAILURE in 39m 32s
cifmw-crc-podified-edpm-baremetal FAILURE in 37m 58s

@slawqo slawqo closed this Nov 23, 2023
@slawqo slawqo deleted the issue/OSPRH-1504 branch November 23, 2023 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant