Deduplicate related images

[fao89]

Ensuring controlplane and dataplane operator share the same hash when the related image has the same name

context: https://issues.redhat.com/browse/OSPRH-1504
openstack-k8s-operators/dataplane-operator#534

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fao89
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fao89]

/test

[openshift-ci]

@fao89: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test functional
• /test images
• /test openstack-operator-build-deploy
• /test openstack-operator-build-deploy-kuttl
• /test precommit-check

The following commands are available to trigger optional jobs:

• /test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openstack-k8s-operators-openstack-operator-main-functional
• pull-ci-openstack-k8s-operators-openstack-operator-main-images
• pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
• pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fao89]

/test all

[fao89]

recheck

[fao89]

/test openstack-operator-build-deploy-kuttl

[dprince]

@fao89 so I'm mixed on doing validations with csv-merger. At some point I might actually like to eliminate this tool however it is still required for now.

One idea for validations is to perhaps use 'scorecard' tests. Scorecard allows use to have custom validations for which I have started putting together a few things here: https://github.com/dprince/scorecard-openstack/blob/main/main.go I presented this a few weeks back and it didn't get much interest. But I still think it is perhaps a good validation layer. Wdyt?

[dprince]

Also, to follow up on what I said about 'bundle validate' I think it is actually 'USE_IMAGE_DIGESTS=true make bundle' which checks for duplicate images. So not exactly what you'd need here.

[fao89]

I liked the scorecard tests, it would same me time if we already had them (I had to do some hacking to manually test the CSV).

Actually, about the duplication, when I started this openstack-k8s-operators/dataplane-operator#534 it was breaking the kuttl tests because the CSV was invalid, that's what made me start this PR. Having the same var name in dataplane-operator and ovn-operator was duplicating the vars as we just use append, so this was what motivated me to start this PR

[dprince]

I liked the scorecard tests, it would same me time if we already had them (I had to do some hacking to manually test the CSV).

Actually, about the duplication, when I started this openstack-k8s-operators/dataplane-operator#534 it was breaking the kuttl tests because the CSV was invalid, that's what made me start this PR. Having the same var name in dataplane-operator and ovn-operator was duplicating the vars as we just use append, so this was what motivated me to start this PR

Do you have a link showing the failure you hit? That PR is passing now it seems

[fao89]

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openstack-k8s-operators_dataplane-operator/534/pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl/1728075030333493248

[fao89]

@dprince did you have a chance to review this PR?
Some parts are "dataplane smart" but others are needed, for example: the related images are currently being dropped

[fao89]

closing in favor of #712