Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-25794: [release-4.14] conformance-test: Filter NIC by environment variable #875

Merged
merged 1 commit into from
Dec 22, 2023
Merged

OCPBUGS-25794: [release-4.14] conformance-test: Filter NIC by environment variable #875

merged 1 commit into from
Dec 22, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Dec 21, 2023

@zeeke
conformance-test: Filter NIC by env var
2959c54 
In order to verify a specific NIC works well with
the operator, the user who runs the test suite should
be able to select involved devices.

This commit introduces the environment variable
`SRIOV_NODE_AND_DEVICE_NAME_FILTER` to implement the
selection behavior.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke changed the title [release-4.1] conformance-test: Filter NIC by environment variable [release-4.14] conformance-test: Filter NIC by environment variable Dec 21, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Dec 21, 2023

/jira cherrypick OCPBUGS-25793

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-25793 has been cloned as Jira Issue OCPBUGS-25794. Will retitle bug to link to clone.
/retitle OCPBUGS-25794: [release-4.14] conformance-test: Filter NIC by environment variable

In response to this:

/jira cherrypick OCPBUGS-25793

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] conformance-test: Filter NIC by environment variable OCPBUGS-25794: [release-4.14] conformance-test: Filter NIC by environment variable Dec 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-25794, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor

SchSeba commented Dec 21, 2023

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Dec 21, 2023

/jira refresh

@gregkopels @evgenyz This PR is about adding an environment variable to select which interface use for cnf-tests.
Please take a look and add cherry-pick-approved if it looks good

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-25794, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25793 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25793 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

@gregkopels @evgenyz This PR is about adding an environment variable to select which interface use for cnf-tests.
Please take a look and add cherry-pick-approved if it looks good

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 21, 2023
@openshift-ci openshift-ci bot requested a review from zhaozhanqi December 21, 2023 13:17
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit c6722c5 into openshift:release-4.14 Dec 22, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-25794: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25794 has been moved to the MODIFIED state.

In response to this:

Backport of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-webhook-container-v4.14.0-202312220052.p0.gc6722c5.assembly.stream for distgit sriov-network-webhook.
All builds following this will include this PR.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.