conformance-test: Filter NIC by environment variable #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-test-select-pf
branch
from
475b628 to
5fbefa6
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
reviewed
Oct 1, 2023
There was a problem hiding this comment.
I really like it!
I have one idea let me know what you think about.
we can have a device with the same name but on two different nodes for example:
node0 -> eno1 -> mlx
node1 -> eno1 -> intel
to over come this I will like to propose to extend the env variable to something like
<node>:<device>
both regex support
let me know what do you think
test/util/cluster/cluster.go
Outdated
| } | ||
| } | ||
| return nil, fmt.Errorf("unable to find sriov devices in node %s", node) | ||
|
|
||
| return filteredDevices, nil | ||
| } | ||
|
|
||
| // FindSriovDevices retrieves all valid sriov devices for the given node. |
There was a problem hiding this comment.
nit please update the function comment
It sounds good to me |
zeeke
force-pushed
the
e2e-test-select-pf
branch
from
5fbefa6 to
d59f8c6
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6456540272
💛 - Coveralls |
bn222
reviewed
Oct 2, 2023
test/util/cluster/cluster.go
Outdated
| // Name of environment variable to filter which decives can be discovered by FindSriovDevices and FindOneSriovDevice. | ||
| // The filter is a regexp matched against node names and device name in the form <node_name>:<device_name> | ||
| // | ||
| // For example, givend the following devices in the cluster: |
|
LGTM |
zeeke
force-pushed
the
e2e-test-select-pf
branch
from
d59f8c6 to
9e9a4fe
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
e2e-test-select-pf
branch
from
9e9a4fe to
62e148f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
In order to verify a specific NIC works well with the operator, the user who runs the test suite should be able to select involved devices. This commit introduces the environment variable `SRIOV_NODE_AND_DEVICE_NAME_FILTER` to implement the selection behavior. Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
e2e-test-select-pf
branch
from
62e148f to
09c94a1
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
e0ne
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to verify a specific NIC works well with
the operator, the user who runs the test suite should be able to select involved devices.
This commit introduces the environment variable
SRIOV_DEVICE_NAME_FILTERto implement the selection behavior.examples:
SRIOV_DEVICE_NAME_FILTER=ens1f1tells the test suite to use a specific device selecting it by its nameSRIOV_DEVICE_NAME_FILTER="ens1*"tells the test suite that every device whose name starts with "ens1" can be used by the tests.