Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25794: cnf-tests: sriov-network-operator bump 4.14 #1811

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Feb 2, 2024

SR-IOV Network Operator dependency bumped with commands:

go mod download github.com/openshift/[email protected]
go mod edit -replace \
github.com/k8snetworkplumbingwg/sriov-network-operator=\
github.com/openshift/[email protected]
go mod tidy
go mod vendor

SR-IOV Network Operator dependency bumped with commands:

```
go mod download github.com/openshift/[email protected]
go mod edit -replace \
github.com/k8snetworkplumbingwg/sriov-network-operator=\
github.com/openshift/[email protected]
go mod tidy
go mod vendor
```

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 2, 2024
@openshift-ci openshift-ci bot requested review from Missxiaoguo and yuvalk February 2, 2024 15:58
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 2, 2024
@openshift-ci-robot
Copy link
Collaborator

@zeeke: This pull request references Jira Issue OCPBUGS-25794, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25793 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25793 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

SR-IOV Network Operator dependency bumped with commands:

go mod download github.com/openshift/[email protected]
go mod edit -replace \
github.com/k8snetworkplumbingwg/sriov-network-operator=\
github.com/openshift/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@zeeke
Copy link
Member Author

zeeke commented Feb 5, 2024

/retest

1 similar comment
@zeeke
Copy link
Member Author

zeeke commented Feb 22, 2024

/retest

@zeeke
Copy link
Member Author

zeeke commented Feb 22, 2024

@SchSeba , @fedepaol PTAL

@zeeke
Copy link
Member Author

zeeke commented Feb 26, 2024

@SchSeba , @fedepaol , @liornoy plain sriov-network-operator dependency update here.
Please, take a look

@liornoy
Copy link
Contributor

liornoy commented Feb 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@liornoy
Copy link
Contributor

liornoy commented Feb 29, 2024

Look like the e2e-aws-ci-tests job failed on unrelated test, however I don't have permission to override.

@zeeke
Copy link
Member Author

zeeke commented Feb 29, 2024

Thanks @liornoy

I confirm test case

CNF Features e2e integration tests: [rfe_id:27368][performance] KubeletConfig experimental annotation should override system-reserved memory

is failing on all 4.14 PRs

/override ci/prow/e2e-aws-ci-tests

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-aws-ci-tests

In response to this:

Thanks @liornoy

I confirm test case

CNF Features e2e integration tests: [rfe_id:27368][performance] KubeletConfig experimental annotation should override system-reserved memory

is failing on all 4.14 PRs

/override ci/prow/e2e-aws-ci-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c85e57d into openshift-kni:release-4.14 Feb 29, 2024
5 checks passed
@openshift-ci-robot
Copy link
Collaborator

@zeeke: Jira Issue OCPBUGS-25794: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25794 has been moved to the MODIFIED state.

In response to this:

SR-IOV Network Operator dependency bumped with commands:

go mod download github.com/openshift/[email protected]
go mod edit -replace \
github.com/k8snetworkplumbingwg/sriov-network-operator=\
github.com/openshift/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants