OCPBUGS-8266: Downstream Sync 2023-09-19 #824
Conversation
If a user creates an SriovNetwork with a network namespace that doesn't exist, retrying reconciling with an exponential backoff is not efficient, as the routing will fail until the namespace is created. This patch makes the controller watch Namespace resource creation and reconcile the related SriovNetworks if needed. Signed-off-by: Andrea Panattoni <[email protected]>
Apply the same namespace reaction as the SriovNetwork Signed-off-by: Andrea Panattoni <[email protected]>
Modify the k8sreporter/reporter.go to utilize the latest external k8s-reporter package. The new reporter still outputs the same output as before plus the CRDs: SriovOperatorConfig and SriovNetwork. It is used by the conformance and validation suites, consumes the flag "-report" as the path to where the dir "sriov_failure_report.log" will be created and hold all of the failed tests logs. Also removed the unused `-junit` flag, as we're using Ginkgo's built it --junit-report tool. Added the `-report` flag to the run-e2e-conformance.sh script. Signed-off-by: Lior Noy <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Utilize the k8s-reporter in the e2e tests
Signed-off-by: Lior Noy <[email protected]>
|
/retest |
design doc for the externally-manage-pf support
|
/retest |
|
/lgtm |
test/util/k8sreporter/reporter.go
Outdated
| switch { | ||
| case ns == namespaces.Test: | ||
| return true | ||
| case ns == "openshift-sriov-network-operator": |
There was a problem hiding this comment.
ohhh I miss this one in the u/s review??
there is a variable for the operator namespace please use that one and not this string.
you will need to open the PR u/s first
There was a problem hiding this comment.
@SchSeba I am looking at the code and don't see a variable that is available for use.
I mean, there is a private const in the controllers package, and a private var in the conformance/tests package.
Do you propose to export the one in the conformance/tests package?
There was a problem hiding this comment.
I think @SchSeba is referring to the OPEATOR_NAMESPACE environment variable:
It's used in other places in the test suite:
There was a problem hiding this comment.
Thank you. I filed this: k8snetworkplumbingwg/sriov-network-operator#506
There was a problem hiding this comment.
The PR upstream merged, I rebased this one.
SriovNetwork: react on namespace creation
This commit modifies the k8s reporter to fetch the namesapce from the env var OPERATOR_NAMESPACE. Signed-off-by: Lior Noy <[email protected]>
Use the OPERATOR_NAMESPACE var in the k8sreporter
|
/retitle OCPBUGS-8266: Downstream Sync 2023-09-19 |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@liornoy: This pull request references Jira Issue OCPBUGS-8266, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@liornoy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liornoy, SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@liornoy: Jira Issue OCPBUGS-8266: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8266 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR brings the K8S reporter commit from upstream.
This enables us to run the E2E tests with the
-reportflag andget a K8S reporter to help us troubleshoot failed tests.