Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the OPERATOR_NAMESPACE var in the k8sreporter #506

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Use the OPERATOR_NAMESPACE var in the k8sreporter #506

merged 1 commit into from
Sep 19, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented Sep 19, 2023

This commit modifies the k8s reporter to fetch the namesapce from the env var OPERATOR_NAMESPACE.

@liornoy
Use the OPERATOR_NAMESPACE var in the k8sreporter
55de991 
This commit modifies the k8s reporter to fetch the namesapce
from the env var OPERATOR_NAMESPACE.

Signed-off-by: Lior Noy <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@liornoy liornoy mentioned this pull request Sep 19, 2023
Merged
@zeeke zeeke mentioned this pull request Sep 19, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6234375921

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 25.786%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 69.77%
controllers/sriovnetwork_controller.go 2 69.77%
Totals Coverage Status
Change from base Build 6185490527: 0.01%
Covered Lines: 2166
Relevant Lines: 8400
💛 - Coveralls

zeeke
zeeke approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rollandf
Copy link
Contributor

LGTM

@zeeke zeeke merged commit 2097c2a into k8snetworkplumbingwg:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liornoy @coveralls @rollandf @zeeke