Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18409: [release-4.13] Allow creating policies that ignore NUMA topology #798

Merged
merged 5 commits into from
Sep 1, 2023
Merged

OCPBUGS-18409: [release-4.13] Allow creating policies that ignore NUMA topology #798

merged 5 commits into from
Sep 1, 2023

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Jul 7, 2023 •
edited
Loading

@vrindle @zeeke
General cleanup in validate.go
259d2da 
We use more expressive return types and also reduce cyclomatic complexity.
@openshift-ci openshift-ci bot requested review from fepan and s1061123 July 7, 2023 10:12
@zeeke zeeke changed the title 4.13 exclude topology [release-4.13] Allow creating policies that ignore NUMA topology Jul 7, 2023
zeeke added 3 commits July 7, 2023 12:28
@zeeke
Refactor renderDevicePluginConfigData
7879463 
The function mainly creates and updates ResourceConfig
in the list. Split the function into two smaller ones.

Adjust unit test to satisfy `SriovNetworkNodePolicyReconciler`
dependencies through fake client.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Add ExcludeNUMATopology to NodePolicy CR
53efe70 
Add field `SriovNetworkNodePolicy.Spec.ExcludeTopology` and
forward it to the sriov-device-plugin configuration.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke
Validate excludeTopology field
45a685c 
Multiple SriovNetworkNodePolicies may target the same
resource, but the new field must have the same value. Add
a resource validation step to ensure this condition is met.

Refactor `Spec.NicSelector.PfNames` check to its own function.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the 4.13-exclude-topology branch from aab8900 to 45a685c Compare July 7, 2023 10:28
@zeeke
Copy link
Contributor Author

zeeke commented Jul 7, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Jul 10, 2023

/retest

@zeeke
Copy link
Contributor Author

zeeke commented Jul 10, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

@zeeke: The following commands are available to trigger required jobs:

  • /test api
  • /test ci-index
  • /test controllers
  • /test gofmt
  • /test images
  • /test operator-e2e
  • /test pkg

The following commands are available to trigger optional jobs:

  • /test e2e-openstack-nfv
  • /test e2e-openstack-nfv-hwoffload

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
Copy link
Contributor Author

zeeke commented Jul 25, 2023

@SchSeba , @bn222 please take a look

cc @vrindle

SchSeba
SchSeba reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeeke you are missing the make manifest bundle

I don't see the CRD updated on the bundle folder

@zeeke
ocp: make manifests bundle
6582cba 
Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke mentioned this pull request Aug 31, 2023
Merged
@zeeke
Copy link
Contributor Author

zeeke commented Aug 31, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
@zeeke
Copy link
Contributor Author

zeeke commented Aug 31, 2023

@SchSeba @bn222 PTAL

This relates to https://issues.redhat.com/browse/CNF-9055

@bn222
Copy link
Contributor

bn222 commented Aug 31, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2023
@SchSeba
Copy link
Contributor

SchSeba commented Aug 31, 2023

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zeeke
Copy link
Contributor Author

zeeke commented Aug 31, 2023

/jira cherrypick OCPBUGS-18407

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-18407 has been cloned as Jira Issue OCPBUGS-18409. Will retitle bug to link to clone.
/retitle OCPBUGS-18409: [release-4.13] Allow creating policies that ignore NUMA topology

In response to this:

/jira cherrypick OCPBUGS-18407

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] Allow creating policies that ignore NUMA topology OCPBUGS-18409: [release-4.13] Allow creating policies that ignore NUMA topology Aug 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-18409, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18407 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-18407 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of

Adding

to avoid conflicst

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 31, 2023
@openshift-ci openshift-ci bot requested a review from zhaozhanqi August 31, 2023 13:34
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-18409, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18407 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-18407 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

Backport of

Adding

to avoid conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke zeeke mentioned this pull request Aug 31, 2023
Merged
@zhaozhanqi
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2023

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ea8f391 into openshift:release-4.13 Sep 1, 2023
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-18409: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18409 has been moved to the MODIFIED state.

In response to this:

Backport of

Adding

to avoid conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@fepan fepan Awaiting requested review from fepan

@s1061123 s1061123 Awaiting requested review from s1061123

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@weliang1 weliang1

@bn222 bn222

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.