[release-4.13] Backport of [sriov] NUMA ExcludeTopology test cases
#1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeke
changed the title
[sriov] NUMA ExcludeTopology test cases[sriov] NUMA ExcludeTopology test cases
zeeke
force-pushed
the
4.13-sriov-numa
branch
from
d5d0d3a to
72f670f
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
SR-IOV Network Operator dependency bumped with commands: ``` go mod edit -replace \ github.com/k8snetworkplumbingwg/sriov-network-operator=\ github.com/openshift/[email protected] go mod tidy go mod vendor ``` Signed-off-by: Andrea Panattoni <[email protected]>
Test cases uses a set SriovNetworkNodePolicies that targets at least two NIC, placed on two different NUMA nodes. Playing with the `excludeTopology` field, is it possible to create workload pod that uses multiple or a single NUMA node. Signed-off-by: Andrea Panattoni <[email protected]>
Test cases uses a set SriovNetworkNodePolicies and performance profile to control NUMA node placement in test. This test creates a pod with sriov interface on NUMA node 1 with the sriov interface in NUMA node 0. The excludeTopology is set to True. THe pod is expected to be deployed.
Add a test case where all Virtual Function that belongs to an SriovNetworkNodePolicy with `ExcludeTopology = true` are consumed. Test logic verifies further pods deployments get "Insufficient resource" errors, then frees some VFs and pod can be scheduled again. Signed-off-by: Andrea Panattoni <[email protected]>
Guaranteed workload pod can be in a different cgroup if on the node there have been applied a PerformanceProfile. The Cluster Node Tuning Operator configures the cpuset cgroup on specific condition and it doesn't come back to the original configuration when the node is moved to a differenent MachineConfigPool. Refs: https://github.com/openshift/cluster-node-tuning-operator/blob/a4c70abb71036341dfaf0cac30dab0d166e55cbd/assets/performanceprofile/scripts/cpuset-configure.sh#L9 Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: Andrea Panattoni <[email protected]>
Make NUMA/SR-IOV integration tests creating their own KubeletConfig that sets single-numa-node policy and reserve an enitre NUMA node to system. Add functions to manipulate `node-role.kubernetes.io/x` labels on node to apply the performacen profile to arbitrary nodes. Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
4.13-sriov-numa
branch
from
72f670f to
306f510
Compare
|
@zeeke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs
Cherry pick of
cc @gregkopels