Allow creating policies that ignore NUMA topology #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5135001239
💛 - Coveralls |
zeeke
changed the title
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
approved these changes
May 9, 2023
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
| @@ -57,6 +57,8 @@ type SriovNetworkNodePolicySpec struct { | |||
| // +kubebuilder:validation:Enum=virtio | |||
| // VDPA device type. Allowed value "virtio" | |||
| VdpaType string `json:"vdpaType,omitempty"` | |||
| // Exclude device's NUMA node when advertising this resource. Default to false. | |||
There was a problem hiding this comment.
nit: Exclude device's NUMA node when advertising this resource by sriov network device plugin
6 tasks
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@zeeke lets rebase and we are good 2 go with merging this one |
The function mainly creates and updates ResourceConfig in the list. Split the function into two smaller ones. Adjust unit test to satisfy `SriovNetworkNodePolicyReconciler` dependencies through fake client. Signed-off-by: Andrea Panattoni <[email protected]>
Add field `SriovNetworkNodePolicy.Spec.ExcludeTopology` and forward it to the sriov-device-plugin configuration. Signed-off-by: Andrea Panattoni <[email protected]>
Multiple SriovNetworkNodePolicies may target the same resource, but the new field must have the same value. Add a resource validation step to ensure this condition is met. Refactor `Spec.NicSelector.PfNames` check to its own function. Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
approved these changes
Jun 1, 2023
adrianchiris
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to create policies that set the sriov-network-device plugin
ExcludeTopologyfield in the advertised resource list.The feature is helpful in scenarios where the kubelet is configured with
--topology-manager-policy single-numa-node[2] and some workloads may run with a NIC that is not aligned to the CPU/Memory NUMA node.[1] https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/master/pkg/types/types.go#L101
[2] https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/#policy-single-numa-node