conformance-test: ExcludeTopology field #451

zeeke · 2023-06-01T08:29:12Z

Add an End2End to validate two different
SriovNetworkNodePolicies can't specify different
ExcludeTopology values for the same resource.

Needs:

Allow creating policies that ignore NUMA topology #435

github-actions · 2023-06-01T08:29:30Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-06-01T09:17:13Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

When creating a new test ClientSet, it's useful to log errors to the console. Signed-off-by: Andrea Panattoni <[email protected]>

coveralls · 2023-06-01T09:24:11Z

Pull Request Test Coverage Report for Build 5645670366

0 of 0 changed or added relevant lines in 0 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 24.547%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovibnetwork_controller.go	6	64.15%

Totals
Change from base Build 5610901679:	0.04%
Covered Lines:	2085
Relevant Lines:	8494

💛 - Coveralls

github-actions · 2023-06-01T09:24:32Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2023-06-19T15:12:54Z

This looks great!
can you please add a test to validate that the config-map we create for the device plugin takes this change into account?

github-actions · 2023-06-20T12:16:13Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke · 2023-06-20T12:18:25Z

This looks great! can you please add a test to validate that the config-map we create for the device plugin takes this change into account?

I added a test case. I'm not 100% happy with asserting the configuration by matching strings, but the alternative (like deserializing the ResourceConfig) would be more complicated. Do you have opinion on that?

github-actions · 2023-06-21T12:25:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

the test looks good.

just small comments

test/conformance/tests/test_sriov_operator.go

github-actions · 2023-06-21T15:22:12Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-06-21T15:24:36Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke · 2023-07-07T07:21:40Z

@SchSeba @Eoghan1232 @adrianchiris Can you please take a look ?

adrianchiris · 2023-07-23T12:59:10Z

test/conformance/tests/test_sriov_operator.go

+
+					intf := unusedSriovDevices[0]
+
+					excludeTopologyTrue := &sriovv1.SriovNetworkNodePolicy{


excludeTopologyTrue, excludeTopologyFalse can be moved to common place under Context ?

i see they both defined the same in both test cases.

I moved the declaration under Context. BTW, assignments need the node name and the interface name, so I had to put them under BeforeEach. WDYT?

adrianchiris · 2023-07-23T13:00:13Z

Overall looks good, one small comment and we can merge IMO

Add an End2End to validate two different SriovNetworkNodePolicies can't specify different `ExcludeTopology` values for the same resource. Verify excludeTopology field is correctly forwarded to the sriov-device-plugin configuration. Signed-off-by: Andrea Panattoni <[email protected]>

github-actions · 2023-07-24T13:49:11Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke force-pushed the exclude-topology-conformance-test branch from 2390dd5 to c74f52a Compare June 1, 2023 09:16

e2e: log warning in case of errors

33eb5aa

When creating a new test ClientSet, it's useful to log errors to the console. Signed-off-by: Andrea Panattoni <[email protected]>

zeeke force-pushed the exclude-topology-conformance-test branch from c74f52a to ee19629 Compare June 1, 2023 09:24

zeeke changed the title ~~conformance-test:~~ conformance-test: ExcludeTopology field Jun 16, 2023

zeeke force-pushed the exclude-topology-conformance-test branch from ee19629 to 412fd79 Compare June 20, 2023 12:16

zeeke force-pushed the exclude-topology-conformance-test branch from 412fd79 to cd785a8 Compare June 21, 2023 12:25

SchSeba reviewed Jun 21, 2023

View reviewed changes

test/conformance/tests/test_sriov_operator.go Outdated Show resolved Hide resolved

test/conformance/tests/test_sriov_operator.go Outdated Show resolved Hide resolved

test/conformance/tests/test_sriov_operator.go Outdated Show resolved Hide resolved

zeeke force-pushed the exclude-topology-conformance-test branch from cd785a8 to 328a4ad Compare June 21, 2023 15:21

zeeke force-pushed the exclude-topology-conformance-test branch from 328a4ad to a30be01 Compare June 21, 2023 15:24

adrianchiris reviewed Jul 23, 2023

View reviewed changes

zeeke force-pushed the exclude-topology-conformance-test branch from a30be01 to c3b8137 Compare July 24, 2023 13:48

adrianchiris approved these changes Jul 24, 2023

View reviewed changes

adrianchiris merged commit 990648e into k8snetworkplumbingwg:master Jul 24, 2023

zeeke mentioned this pull request Jul 24, 2023

e2e: Fix Validate ExcludeTopology test leftover #482

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

conformance-test: ExcludeTopology field #451

conformance-test: ExcludeTopology field #451

zeeke commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

coveralls commented Jun 1, 2023 •

edited

Loading

github-actions bot commented Jun 1, 2023

SchSeba commented Jun 19, 2023

github-actions bot commented Jun 20, 2023

zeeke commented Jun 20, 2023

github-actions bot commented Jun 21, 2023

SchSeba left a comment

github-actions bot commented Jun 21, 2023

github-actions bot commented Jun 21, 2023

zeeke commented Jul 7, 2023

adrianchiris Jul 23, 2023

zeeke Jul 24, 2023

adrianchiris commented Jul 23, 2023

github-actions bot commented Jul 24, 2023


		intf := unusedSriovDevices[0]

		excludeTopologyTrue := &sriovv1.SriovNetworkNodePolicy{

conformance-test: ExcludeTopology field #451

conformance-test: ExcludeTopology field #451

Conversation

zeeke commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

coveralls commented Jun 1, 2023 • edited Loading

Pull Request Test Coverage Report for Build 5645670366

💛 - Coveralls

github-actions bot commented Jun 1, 2023

SchSeba commented Jun 19, 2023

github-actions bot commented Jun 20, 2023

zeeke commented Jun 20, 2023

github-actions bot commented Jun 21, 2023

SchSeba left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 21, 2023

github-actions bot commented Jun 21, 2023

zeeke commented Jul 7, 2023

adrianchiris Jul 23, 2023

Choose a reason for hiding this comment

zeeke Jul 24, 2023

Choose a reason for hiding this comment

adrianchiris commented Jul 23, 2023

github-actions bot commented Jul 24, 2023

coveralls commented Jun 1, 2023 •

edited

Loading