Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix Validate ExcludeTopology test leftover #482

Merged

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Jul 24, 2023

Fix coding errors introduced while refactoring

cc @adrianchiris

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5646836853

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 24.511%

Totals Coverage Status
Change from base Build 5645891211: 0.06%
Covered Lines: 2082
Relevant Lines: 8494

💛 - Coveralls

@zeeke zeeke changed the title e2e: Fix Validate ExcludeTopology field e2e: Fix Validate ExcludeTopology test leftover Jul 27, 2023
@zeeke
Copy link
Member Author

zeeke commented Jul 27, 2023

@adrianchiris , @SchSeba, unfortunately I left over some errors during my last push on previous PR.

Can you please take a look at this?

Sorry for the inconvenience

@e0ne
Copy link
Collaborator

e0ne commented Aug 1, 2023

@zeeke can we get some CI results before merging this?

@zeeke
Copy link
Member Author

zeeke commented Aug 2, 2023

Hi @e0ne, we are working to run this test suite closer to this repository, but we're still hitting some virtualization challenges.

Attached are reports of running make test-e2e-conformance against an OpenShift 4.13 cluster, on master and pr branch, focusing on ExcludeTopology testcases

master.output.txt
master_unit_report.xml.txt
pr.output.txt
pr_unit_report.xml.txt

This PR fixes

• [FAILED] [77.393 seconds]
[sriov] operator Custom SriovNetworkNodePolicy Configuration ExcludeTopology [It] field is forwarded to the device plugin configuration
/home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1444

  [FAILED] Timed out after 30.000s.
  Expected
      <map[string]string | len:2>: {
          "dhcp19-17-171.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":null}",
          "cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": "{\"resourceList\":[{\"resourceName\":\"resourceXXX\",\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}]}",
      }
  to have {key: value} matching
      <map[interface {}]interface {} | len:1>: {
          <string>"cnfdd5.clus2.t5g.lab.eng.bos.redhat.com": <*matchers.ContainSubstringMatcher | 0xc000874ba0>{
              Substr: "{\"resourceName\":\"resourceXXX\",\"excludeTopology\":true,\"selectors\":{\"pfNames\":[\"eno2np1#0-4\"],\"IsRdma\":false,\"NeedVhostNet\":false},\"SelectorObj\":null}",
              Args: nil,
          },
      }
  In [It] at: /home/apanatto/dev/github.com/k8snetworkplumbingwg/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2244 @ 08/02/23 10:08:37.741

@e0ne
Copy link
Collaborator

e0ne commented Aug 2, 2023

@zeeke thanks for the information!

@e0ne e0ne merged commit 12b2566 into k8snetworkplumbingwg:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants