Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync master 16 08 22 #686

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Sync master 16 08 22 #686

merged 4 commits into from
Aug 22, 2022

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Aug 16, 2022

No description provided.

e0ne and others added 3 commits August 11, 2022 19:05
@e0ne @zeeke
Remove OnNodeStateAdd method from plugins
45c1acb 
All implementations of OnNodeStateAdd method are the same as
OnNodeStateChange, so we don't need this code dublication.
@e0ne @zeeke
Remove 'old' argument from plugins OnNodeStateChange method
07b63f3 
'old' argument is not used in any existing plugin.

We can re-visit this change if some plugin requires it in the future.
@zeeke
Remove go get <binary> instances
44b4ec0 
Go getting bninaries has been deprecated in go1.17 and not supported
in go1.18.

Signed-off-by: Andrea Panattoni <[email protected]>
@SchSeba
Copy link
Contributor Author

SchSeba commented Aug 16, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@openshift-ci openshift-ci bot requested review from bn222 and zshi-redhat August 16, 2022 11:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@SchSeba SchSeba force-pushed the sync_master_16_08_22 branch from c83bf87 to 05e5f98 Compare August 16, 2022 12:59
@SchSeba
Copy link
Contributor Author

SchSeba commented Aug 16, 2022

/retest

@zeeke
Copy link
Contributor

zeeke commented Aug 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@bn222
Copy link
Contributor

bn222 commented Aug 17, 2022

/lgtm

@zeeke
Copy link
Contributor

zeeke commented Aug 17, 2022

Wait for

This was referenced Aug 17, 2022
Merged
Closed
@zeeke @SchSeba
Set mod=readonly when installing binaries
c70100d 
If no `-mod` argument is specified, GOLFAGS environment
variable takes place. If it contains `mod=vendor` (like Makefile
actually does), goinstall can fail with:

```
go install: github.com/onsi/ginkgo/[email protected]: cannot query module due to -mod=vendor
```

Signed-off-by: Andrea Panattoni <[email protected]>
@SchSeba SchSeba force-pushed the sync_master_16_08_22 branch from 05e5f98 to c70100d Compare August 21, 2022 14:22
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2022

@SchSeba: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv c70100d link false /test e2e-openstack-nfv
ci/prow/e2e-openstack-nfv-hwoffload c70100d link false /test e2e-openstack-nfv-hwoffload

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor Author

SchSeba commented Aug 21, 2022

/cc @bn222

@zeeke
Copy link
Contributor

zeeke commented Aug 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@bn222
Copy link
Contributor

bn222 commented Aug 22, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SchSeba
Copy link
Contributor Author

SchSeba commented Aug 22, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit a7010e3 into openshift:master Aug 22, 2022
SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Aug 27, 2024
@SchSeba
Merge pull request openshift#686 from thom311/th/script-exit-on-error
34dcef5 
Let "depoly-setup.sh" and "undeploy.sh" fail on error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn222 bn222 Awaiting requested review from bn222

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@zeeke zeeke

@bn222 bn222

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SchSeba @zeeke @bn222 @openshift-merge-robot @e0ne