-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set mod=readonly
when installing binaries
#351
Merged
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
zeeke:fix-ginkgo-download
Aug 21, 2022
Merged
Set mod=readonly
when installing binaries
#351
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
zeeke:fix-ginkgo-download
Aug 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 2874086304
💛 - Coveralls |
Thanks for your PR,
To skip the vendors CIs use one of:
|
Build is failing due to go1.19, fixed in |
If no `-mod` argument is specified, GOLFAGS environment variable takes place. If it contains `mod=vendor` (like Makefile actually does), goinstall can fail with: ``` go install: github.com/onsi/ginkgo/[email protected]: cannot query module due to -mod=vendor ``` Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
fix-ginkgo-download
branch
from
August 19, 2022 07:50
bc3acdf
to
fea8756
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
/lgtm |
SchSeba
approved these changes
Aug 21, 2022
adrianchiris
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
-mod
argument is specified, GOLFAGS environmentvariable takes place. If it contains
mod=vendor
(like Makefileactually does), goinstall can fail with:
Signed-off-by: Andrea Panattoni [email protected]