Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mod=readonly when installing binaries #351

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Aug 17, 2022

If no -mod argument is specified, GOLFAGS environment
variable takes place. If it contains mod=vendor (like Makefile
actually does), goinstall can fail with:

go install: github.com/onsi/ginkgo/[email protected]: cannot query module due to -mod=vendor

Signed-off-by: Andrea Panattoni [email protected]

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Aug 17, 2022

Pull Request Test Coverage Report for Build 2874086304

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 15.677%

Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 67.0%
api/v1/helper.go 3 34.8%
controllers/sriovibnetwork_controller.go 6 63.37%
Totals Coverage Status
Change from base Build 2841240107: -0.2%
Covered Lines: 1146
Relevant Lines: 7310

💛 - Coveralls

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke
Copy link
Member Author

zeeke commented Aug 17, 2022

Build is failing due to go1.19, fixed in

If no `-mod` argument is specified, GOLFAGS environment
variable takes place. If it contains `mod=vendor` (like Makefile
actually does), goinstall can fail with:

```
go install: github.com/onsi/ginkgo/[email protected]: cannot query module due to -mod=vendor
```

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the fix-ginkgo-download branch from bc3acdf to fea8756 Compare August 19, 2022 07:50
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 21, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Aug 21, 2022
@adrianchiris adrianchiris merged commit d46bc6d into k8snetworkplumbingwg:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants