Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync master 2022-08-11 #684

Closed
wants to merge 3 commits into from
Closed

Sync master 2022-08-11 #684

wants to merge 3 commits into from

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Aug 11, 2022

No description provided.

e0ne and others added 3 commits August 11, 2022 19:05
@e0ne @zeeke
Remove OnNodeStateAdd method from plugins
45c1acb 
All implementations of OnNodeStateAdd method are the same as
OnNodeStateChange, so we don't need this code dublication.
@e0ne @zeeke
Remove 'old' argument from plugins OnNodeStateChange method
07b63f3 
'old' argument is not used in any existing plugin.

We can re-visit this change if some plugin requires it in the future.
@zeeke
Remove go get <binary> instances
44b4ec0 
Go getting bninaries has been deprecated in go1.17 and not supported
in go1.18.

Signed-off-by: Andrea Panattoni <[email protected]>
@openshift-ci openshift-ci bot requested review from Billy99 and dougbtv August 11, 2022 17:10
@SchSeba
Copy link
Contributor

SchSeba commented Aug 16, 2022

/retest

@SchSeba
Copy link
Contributor

SchSeba commented Aug 16, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@SchSeba
Copy link
Contributor

SchSeba commented Aug 16, 2022

Hi @zeeke I think we are still missing something maybe we change the go mod to not be vendor when we want to install the ginkgo package?

�[36mINFO�[0m[2022-08-16T10:26:24Z] SUITE=./test/validation ./hack/run-e2e-conformance.sh	
+ which ginkgo
which: no ginkgo in (/opt/google/protobuf/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/go/bin)
+ '[' 1 -ne 0 ']'
++ mktemp -d
+ GINKGO_TMP_DIR=/tmp/tmp.ITwMvxlt11
+ cd /tmp/tmp.ITwMvxlt11
+ go mod init tmp
go: creating new go.mod: module tmp
+ go install github.com/onsi/ginkgo/[email protected]
go install: github.com/onsi/ginkgo/[email protected]: cannot query module due to -mod=vendor
+ rm -rf /tmp/tmp.ITwMvxlt11
+ echo 'Downloading ginkgo tool'
Downloading ginkgo tool

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 772737c and 8 for PR HEAD 44b4ec0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 772737c and 7 for PR HEAD 44b4ec0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 772737c and 6 for PR HEAD 44b4ec0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e 44b4ec0 link true /test operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor

SchSeba commented Aug 18, 2022

closing in favor of #686

/close

@openshift-ci openshift-ci bot closed this Aug 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2022

@SchSeba: Closed this PR.

In response to this:

closing in favor of #686

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Apr 24, 2024
@SchSeba
Merge pull request openshift#684 from SchSeba/support_k8s_cluster_ver…
b7ec5ae 
…sion

add support to specifi cluster version for k8s CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Billy99 Billy99 Awaiting requested review from Billy99

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees

@SchSeba SchSeba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeeke @SchSeba @openshift-ci-robot @e0ne