Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Cherry-pick from upstream #641

Closed

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Mar 15, 2022

EmilienM and others added 3 commits March 15, 2022 14:52
As well known and well documented, in virtual deployments of Kubernetes such as running on top
of OpenStack where the underlying virtualization platform is KVM, it does not support a virtualized iommu,
the VFIO PCI driver needs to be loaded with a special flag.

This patch aims to do it by default in the virtual_plugin, since this
plugin is only used by OpenStack for now.

Note: it also changes `utils.LoadKernelModule` function to support
kernel module arguments. It also adds a note in `load-kmod.sh` about the
fact that a module won't be reloaded with potential new options if the
module is already loaded on the system.
This commit includes a new dependency that
provides a HTTP client interface with automatic
retries and exponential backoff.
In most cases, OpenStack metadata service is available in the cloud,
which removes the requirement of config-drive.

This patch will change the logic to try reading Metadata and Network data from
the config-drive directory but if it's not present, it'll try to get
it by safely fetching the URL.
@MaysaMacedo MaysaMacedo changed the title Cherry pick openstack openstack: Cherry-pick from upstream Mar 15, 2022
@openshift-ci openshift-ci bot requested review from dougbtv and SchSeba March 15, 2022 15:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaysaMacedo
To complete the pull request process, please assign pliurh after the PR has been reviewed.
You can assign the PR to them by writing /assign @pliurh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/api 573d872 link true /test api
ci/prow/operator-e2e 573d872 link true /test operator-e2e
ci/prow/controllers 573d872 link true /test controllers
ci/prow/pkg 573d872 link true /test pkg
ci/prow/e2e-openstack-nfv 573d872 link false /test e2e-openstack-nfv
ci/prow/images 573d872 link true /test images
ci/prow/ci-index 573d872 link true /test ci-index

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaysaMacedo
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@MaysaMacedo
Copy link
Contributor Author

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

@MaysaMacedo: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants