openstack: include support to metadata service #258

MaysaMacedo · 2022-02-24T17:52:07Z

In most cases, OpenStack metadata service is available in the cloud,
which removes the requirement of config-drive.

This patch will change the logic to try reading Metadata and Network data from
the config-drive directory but if it's not present, it'll try to get
it by safely fetching the URL.

Note: it's adding a new dependency on hashicorp/go-retryablehttp which
is a library which provides a HTTP client interface with automatic retries
and exponential backoff.

github-actions · 2022-02-24T17:52:20Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-02-24T17:58:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

pkg/utils/utils_virtual.go

EmilienM · 2022-02-25T03:36:17Z

pkg/daemon/writer.go

+			writer.metaData, writer.networkData, err = utils.FetchOpenstackData()
+			if err != nil {
+				glog.Errorf("Run(): failed to fetch OpenStack data: %v", err)
+			}


@pierreprinetti I think your feedback from https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/246/files#r803725901 is addressed here. Can you please confirm?

pkg/daemon/writer.go

pkg/utils/utils_virtual.go

github-actions · 2022-03-01T18:11:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

MaysaMacedo · 2022-03-01T18:11:55Z

It worked fine to fetch the metadata service:

I0301 18:00:41.740862   49272 utils_virtual.go:105] ReadOpenstackMetaData(): read OpenStack meta_data from config-drive                                                                       
2022/03/01 18:00:41 [DEBUG] GET http://169.254.169.254/openstack/2018-08-27/meta_data.json                                                                                                    
2022/03/01 18:00:41 [DEBUG] GET http://169.254.169.254/openstack/2018-08-27/network_data.json

EmilienM · 2022-03-01T20:01:24Z

/lgtm
this looks good to me. Thanks!

MaysaMacedo · 2022-03-02T17:20:46Z

@SchSeba can you take a look on this PR? Thanks

EmilienM · 2022-03-08T03:15:53Z

LGTM

adrianchiris · 2022-03-08T17:22:15Z

In most cases, OpenStack metadata service is available in the cloud

should fetching from metadata service be the default ?

pkg/utils/utils_virtual.go

pkg/daemon/writer.go

github-actions · 2022-03-09T13:19:20Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

MaysaMacedo · 2022-03-09T13:23:31Z

In most cases, OpenStack metadata service is available in the cloud

should fetching from metadata service be the default ?

Using config-drive is considered more stable than using metadata, that's why we try to handle it first.
The order chosen was initially proposed by @EmilienM, maybe he has more information about it.

EmilienM · 2022-03-09T14:13:43Z

In most cases, OpenStack metadata service is available in the cloud

should fetching from metadata service be the default ?

Using config-drive is considered more stable than using metadata, that's why we try to handle it first. The order chosen was initially proposed by @EmilienM, maybe he has more information about it.

Right, let's try to read the files first (cheaper & faster than fetching URL), by default, and if it's not there we just fallback into fetching the metadata URL.

MaysaMacedo · 2022-03-10T14:57:53Z

@adrianchiris Thanks for the review. Can you take another look on this PR?

adrianchiris · 2022-03-11T05:42:49Z

/test-all

This commit includes a new dependency that provides a HTTP client interface with automatic retries and exponential backoff.

github-actions · 2022-03-14T16:18:57Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

In most cases, OpenStack metadata service is available in the cloud, which removes the requirement of config-drive. This patch will change the logic to try reading Metadata and Network data from the config-drive directory but if it's not present, it'll try to get it by safely fetching the URL.

github-actions · 2022-03-14T16:23:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

EmilienM · 2022-03-14T18:09:48Z

LGTM

EmilienM · 2022-03-14T18:20:17Z

/test-all

bn222 · 2022-03-15T08:48:08Z

/lgtm

EmilienM reviewed Feb 25, 2022

View reviewed changes

pkg/utils/utils_virtual.go Outdated Show resolved Hide resolved

EmilienM reviewed Feb 25, 2022

View reviewed changes

pkg/utils/utils_virtual.go Outdated Show resolved Hide resolved

EmilienM reviewed Feb 25, 2022

View reviewed changes

EmilienM mentioned this pull request Feb 25, 2022

openstack: fallback to metadata server if config-drive is not deployed #246

Closed

EmilienM reviewed Feb 25, 2022

View reviewed changes

pkg/daemon/writer.go Outdated Show resolved Hide resolved

EmilienM reviewed Feb 25, 2022

View reviewed changes

pkg/utils/utils_virtual.go Outdated Show resolved Hide resolved

MaysaMacedo marked this pull request as ready for review March 1, 2022 18:11

MaysaMacedo changed the title ~~openstack: try to fetch Metadata service first~~ openstack: include support to metadata service Mar 7, 2022

adrianchiris reviewed Mar 8, 2022

View reviewed changes

pkg/utils/utils_virtual.go Show resolved Hide resolved

pkg/utils/utils_virtual.go Show resolved Hide resolved

pkg/utils/utils_virtual.go Show resolved Hide resolved

pkg/daemon/writer.go Outdated Show resolved Hide resolved

adrianchiris approved these changes Mar 10, 2022

View reviewed changes

adrianchiris requested review from SchSeba and zshi-redhat March 13, 2022 09:28

Vendor hashicorp/go-retryablehttp deps

e31b2d0

This commit includes a new dependency that provides a HTTP client interface with automatic retries and exponential backoff.

zshi-redhat approved these changes Mar 15, 2022

View reviewed changes

zshi-redhat merged commit 4616d58 into k8snetworkplumbingwg:master Mar 15, 2022

MaysaMacedo mentioned this pull request Mar 15, 2022

openstack: Cherry-pick from upstream openshift/sriov-network-operator#641

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openstack: include support to metadata service #258

openstack: include support to metadata service #258

MaysaMacedo commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

EmilienM Feb 25, 2022

github-actions bot commented Mar 1, 2022

MaysaMacedo commented Mar 1, 2022

EmilienM commented Mar 1, 2022

MaysaMacedo commented Mar 2, 2022

EmilienM commented Mar 8, 2022

adrianchiris commented Mar 8, 2022

github-actions bot commented Mar 9, 2022

MaysaMacedo commented Mar 9, 2022

EmilienM commented Mar 9, 2022

MaysaMacedo commented Mar 10, 2022

adrianchiris commented Mar 11, 2022

github-actions bot commented Mar 14, 2022

github-actions bot commented Mar 14, 2022

EmilienM commented Mar 14, 2022

EmilienM commented Mar 14, 2022

bn222 commented Mar 15, 2022

openstack: include support to metadata service #258

openstack: include support to metadata service #258

Conversation

MaysaMacedo commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

EmilienM Feb 25, 2022

Choose a reason for hiding this comment

github-actions bot commented Mar 1, 2022

MaysaMacedo commented Mar 1, 2022

EmilienM commented Mar 1, 2022

MaysaMacedo commented Mar 2, 2022

EmilienM commented Mar 8, 2022

adrianchiris commented Mar 8, 2022

github-actions bot commented Mar 9, 2022

MaysaMacedo commented Mar 9, 2022

EmilienM commented Mar 9, 2022

MaysaMacedo commented Mar 10, 2022

adrianchiris commented Mar 11, 2022

github-actions bot commented Mar 14, 2022

github-actions bot commented Mar 14, 2022

EmilienM commented Mar 14, 2022

EmilienM commented Mar 14, 2022

bn222 commented Mar 15, 2022