virtual/openstack: configure VFIO with NIOMMU by default #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
testing it via our CI in OpenShift: #257 |
|
@atyronesmith @SchSeba would you be open to such a change? |
|
Yes! |
|
This worked as expected: |
EmilienM
changed the title
SchSeba
reviewed
Feb 27, 2022
SchSeba
reviewed
Feb 27, 2022
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/hold |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
1 similar comment
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
EmilienM
changed the title
|
/hold cancel |
|
/test-all |
|
/cc @bn222 |
bn222
reviewed
Mar 4, 2022
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/lgtm |
zshi-redhat
approved these changes
Mar 8, 2022
|
/cc @adrianchiris |
|
/lgtm |
|
@adrianchiris when time permits, please merge this one, it was tested, and got several reviews & lgtm. |
adrianchiris
reviewed
Mar 8, 2022
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
As well known and well documented, in virtual deployments of Kubernetes such as running on top of OpenStack where the underlying virtualization platform is KVM, it does not support a virtualized iommu, the VFIO PCI driver needs to be loaded with a special flag. This patch aims to do it by default in the virtual_plugin, since this plugin is only used by OpenStack for now. Note: it also changes `utils.LoadKernelModule` function to support kernel module arguments. It also adds a note in `load-kmod.sh` about the fact that a module won't be reloaded with potential new options if the module is already loaded on the system.
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@adrianchiris thanks for the review, all done. Let me know if there is anything. |
|
/test-all |
This was referenced Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well known and well documented, in virtual deployments of Kubernetes such as running on top
of OpenStack where the underlying virtualization platform is KVM, it does not support a virtualized iommu,
the VFIO PCI driver needs to be loaded with a special flag.
This patch aims to do it by default in the virtual_plugin, since this
plugin is only used by OpenStack for now.
Note: it also changes
utils.LoadKernelModulefunction to supportkernel module arguments. It also adds a note in
load-kmod.shabout thefact that a module won't be reloaded with potential new options if the
module is already loaded on the system.