openstack/nfv: update experimental job #27145
Conversation
openshift-ci
bot
added
the
approved
Use the experimental NFV job to test the improvements made into the virtual plugin for the SR-IOV Network Operator. * Add DPDK to the networkpolicy * Change how the testpmd pod is being deployed to simplify things and not relying on manual CNI edits.
|
/retest |
| @@ -4,8 +4,6 @@ workflow: | |||
| pre: | |||
| - chain: ipi-openstack-pre | |||
| - ref: openstack-provision-performanceprofile | |||
| - ref: openstack-provision-vfio-noiommu | |||
There was a problem hiding this comment.
this is being removed because we're loading from the kernelargs now right?
k8snetworkplumbingwg/sriov-network-operator#257
if yes, do we plan to remove from the other workflows later?
There was a problem hiding this comment.
this is being removed because we're loading from the kernelargs now right?
Yes, once Sebastian's PR to support vhostuser has landed, we can remove openstack-provision-vfio-noiommu because the SR-IOV network operator will take care of it.
if yes, do we plan to remove from the other workflows later?
Absolutely! But first we use the experimental workflow to test things on demand, before changing the "stable" periodic jobs that use the "legacy" manual steps.
Does it make sense?
There was a problem hiding this comment.
sure. I thought this step openstack-provision-vfio-noiommu could already be excluded since this was merged k8snetworkplumbingwg/sriov-network-operator#257
|
|
||
| cat <<EOF > "${SHARED_DIR}/additionalnetwork.yaml" | ||
| if oc get SriovNetworkNodePolicy/dpdk1 -n openshift-sriov-network-operator >/dev/null 2>&1; then | ||
| echo "DPDK network is managed by SriovNetworkNodePolicy/dpdk1, CNI won't be changed" |
There was a problem hiding this comment.
So a Pod created on that host will already have the new interface configured correctly witthout the CNI configure with host-device?
I think we need update on the README https://github.com/openshift/sriov-network-operator/blob/184af61a5406c2c6298eb88c10303d90d5266c76/README.md#sriovnetworknodepolicy.
Let me know what you think and I will try to do.
There was a problem hiding this comment.
Not a Pod but a SriovNetworkNodePolicy.
See:
$ oc describe SriovNetworkNodePolicy/dpdk1 -n openshift-sriov-network-operator
Name: dpdk1
Namespace: openshift-sriov-network-operator
Labels: <none>
Annotations: <none>
API Version: sriovnetwork.openshift.io/v1
Kind: SriovNetworkNodePolicy
Metadata:
Creation Timestamp: 2022-03-21T18:27:37Z
Generation: 1
Managed Fields:
API Version: sriovnetwork.openshift.io/v1
Fields Type: FieldsV1
fieldsV1:
f:spec:
.:
f:deviceType:
f:nicSelector:
.:
f:netFilter:
f:nodeSelector:
.:
f:feature.node.kubernetes.io/network-sriov.capable:
f:numVfs:
f:priority:
f:resourceName:
Manager: kubectl-create
Operation: Update
Time: 2022-03-21T18:27:37Z
Resource Version: 61357
UID: b61924be-aea1-4286-88e9-9fadb991dd88
Spec:
Device Type: vfio-pci
Is Rdma: false
Nic Selector:
Net Filter: openstack/NetworkID:4303a5b3-3406-4044-b19f-c11a18c075bd
Node Selector:
feature.node.kubernetes.io/network-sriov.capable: true
Num Vfs: 1
Priority: 99
Resource Name: dpdk1
Events: <none>We have this condition to detect whether or not we created a SriovNetworkNodePolicy for DPDK, and if not, then we'll patch additionalNetworks in Cluster Network Operator.
Does it make sense?
There was a problem hiding this comment.
Yes. However, why the CNI settings are not needed anymore when the SriovNetworkNodePolicy is available? I'm just wondering at which step the Pod will be configured with the new nic
|
Note for reviewers: |
|
The errors are weird, i wonder if the infra is flacky or under load. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test pj-rehearse |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@EmilienM: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use the experimental NFV job to test the improvements made into the
virtual plugin for the SR-IOV Network Operator.
not relying on manual CNI edits.