Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-6291: Enable Performance tuning for Hypershift nodes #1244

Merged
merged 1 commit into from
Feb 6, 2023
Merged

CNF-6291: Enable Performance tuning for Hypershift nodes #1244

merged 1 commit into from
Feb 6, 2023

Conversation

jlojosnegros
Copy link
Contributor

This enhancement describes the workflow and design changes needed to enable running the Performance Profile controller as part of Node Tuning Operator in the HyperShift hosted control planes to manage node tuning of hosted nodes.

This is part of the phase-3 of NTO adaptation.

For NTO adaptation info see #1229

@openshift-ci openshift-ci bot requested review from csrwng and sjenning September 20, 2022 11:30
@jlojosnegros jlojosnegros mentioned this pull request Sep 20, 2022
Closed
@enxebre
Copy link
Member

enxebre commented Sep 30, 2022

thanks! looks great overall, let's conflate it with #1229, either same file or same folder

@jlojosnegros jlojosnegros mentioned this pull request Oct 4, 2022
Merged
4 tasks
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Oct 7, 2022 •
edited
Loading

thanks! looks great overall, let's conflate it with #1229, either same file or same folder

They already are in the same folder.
enhancements/hypershift/node-tuning.md
enhancements/hypershift/performanceprofilecontroller-node-tuning.md

@jlojosnegros jlojosnegros mentioned this pull request Oct 13, 2022
Closed
@jlojosnegros
Copy link
Contributor Author

/hold
Intended for 4.13

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
@jlojosnegros
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@jlojosnegros
Copy link
Contributor Author

@enxebre @csrwng Please take a look whenever you have some time.

Thanks in advance

csrwng
csrwng reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlojosnegros great stuff. Some comments, questions.

enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
enhancements/hypershift/performanceprofilecontroller-node-tuning.md Outdated Show resolved Hide resolved
@jlojosnegros jlojosnegros force-pushed the pao_hypershift branch 4 times, most recently from 113c9b2 to fdd016b Compare December 19, 2022 14:16
@jlojosnegros jlojosnegros force-pushed the pao_hypershift branch 2 times, most recently from 11c7ff4 to 3d75fcd Compare January 9, 2023 08:28
@jlojosnegros jlojosnegros force-pushed the pao_hypershift branch 2 times, most recently from 42276c7 to 42b2e4e Compare January 17, 2023 08:33
@jlojosnegros jlojosnegros force-pushed the pao_hypershift branch 2 times, most recently from 12d7811 to 4c1d9a4 Compare January 30, 2023 07:56
@jlojosnegros
Copy link
Contributor Author

Hi @enxebre , @csrwng

Do you think this is ready to be merged?

@jlojosnegros jlojosnegros requested review from enxebre and removed request for sjenning February 2, 2023 10:07
@jlojosnegros jlojosnegros requested review from csrwng and enxebre and removed request for enxebre and csrwng February 2, 2023 10:07
@csrwng
Copy link
Contributor

csrwng commented Feb 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@jlojosnegros
Copy link
Contributor Author

@csrwng Thanks for the lgtm label but it seems it has disappear after some rebase.

@jlojosnegros
Enable Performance tuning for Hypershift nodes
f8da7c0 
Adaptation of Performance Profile controller for HyperShift hosted nodes
as part of the Cluster Node Tuning operator adaptation.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@csrwng
Copy link
Contributor

csrwng commented Feb 6, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 192daa6 into openshift:master Feb 6, 2023
@Tal-or Tal-or mentioned this pull request May 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlojosnegros @enxebre @csrwng @openshift-merge-robot