CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

Tal-or · 2024-05-09T14:08:16Z

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation
E2E config suite adoption

Additional gaps which should be addressed on separate PRs, but listed here for transparency:

Status reporting CNF-12680
Retrieve containerruntimeconfig information CNF-11845
Feature Gate support CNF-12711

openshift-ci-robot · 2024-05-09T14:08:21Z

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation

E2E testing

Additional gaps which should be addressed but on separate PRs:

Status reporting

Retrieve containerruntimeconfig information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2024-05-12T06:49:00Z

/retest

pkg/performanceprofile/controller/performanceprofile/hypershift/components/handler.go

pkg/performanceprofile/controller/performanceprofile/hypershift/status/status.go

pkg/performanceprofile/controller/performanceprofile_controller.go

openshift-ci-robot · 2024-05-15T08:30:54Z

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation

E2E testing

Additional gaps which should be addressed but on separate PRs:

Status reporting

Retrieve containerruntimeconfig information

Feature Gate support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-15T08:39:09Z

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation

E2E testing

Additional gaps which should be addressed but on separate PRs:

Status reporting CNF-12680

Retrieve containerruntimeconfig information CNF-11845

Feature Gate support CNF-12711

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-15T08:39:57Z

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation

E2E testing

Additional gaps which should be addressed on separate PRs, but listed here for transparency:

Status reporting CNF-12680

Retrieve containerruntimeconfig information CNF-11845

Feature Gate support CNF-12711

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2024-05-15T13:39:45Z

depends on: #1004

openshift-ci-robot · 2024-05-16T09:22:58Z

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR provides the actual support of PAO/NTO over hypershift platform.
The PR follows the enhancement: openshift/enhancements#1244

More details in the commits themselves.

Implementation

E2E testing

Additional gaps which should be addressed on separate PRs, but listed here for transparency:

Status reporting CNF-12680

Retrieve containerruntimeconfig information CNF-11845

Feature Gate support CNF-12711

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Tal-or · 2024-05-22T12:12:49Z

/retest

pkg/performanceprofile/controller/performanceprofile/hypershift/hypershift.go

Tal-or · 2024-05-28T08:07:09Z

/test e2e-hypershift-pao

Tal-or · 2024-05-28T11:06:29Z

/retest

status reporting is not supported on hypershift yet. we provide a fake implementation in order to conforms the interface. Signed-off-by: Talor Itzhak <[email protected]>

Checking the feature gate first will result with an error on hypershift since it's not yet supported. Signed-off-by: Talor Itzhak <[email protected]>

Adding a management client to be used on a hypershift platform. Signed-off-by: Talor Itzhak <[email protected]>

Add the necessary configuration for the controller, so it would be able to run on a hypershift platform. 1. It needs to configure predicates for ConfigMaps instead of actual objects. 2. It needs to setup different clients for the management cluster and hosted cluster. Signed-off-by: Talor Itzhak <[email protected]>

Modify the reconciliation flow so it could fit for both HCP and OCP. Signed-off-by: Talor Itzhak <[email protected]>

Adding the relevant code for configuring performanceProfile over hypershift Signed-off-by: Talor Itzhak <[email protected]>

Signed-off-by: Talor Itzhak <[email protected]>

Bump needed for handling hypershift APIs. This is the output formatted and generated by the \`go mod tidy\` Signed-off-by: Talor Itzhak <[email protected]>

The package that holds featuregate geatures has changed in the last vendor bump. This commit uses the new paths. Signed-off-by: Talor Itzhak <[email protected]>

- Move logs to V(4) - Fix typos - Remove redundant spacing - Consistent HyperShift naming Signed-off-by: Talor Itzhak <[email protected]>

Tal-or · 2024-06-06T20:13:50Z

Depends on openshift/release#52876

jmencak · 2024-06-07T03:39:10Z

/retest

Tal-or · 2024-06-07T05:41:15Z

/test e2e-hypershift

ffromani

/lgtm
/hold

ffromani · 2024-06-07T07:26:06Z

/hold cancel

because missing approval so no risk of premature merge

ffromani · 2024-06-07T07:26:30Z

/lgtm

yanirq · 2024-06-09T10:22:58Z

/approve

openshift-ci · 2024-06-09T10:23:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-06-09T13:41:52Z

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-06-10T11:00:32Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202406101017.p0.g4d6cb12.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

* pao:hypershift: do not add mco scheme On hypershift we don't have mco, trying to add it will cause for exit with an error * pao:hypershift: implement the components handler interface This is the core of the reconciliation loop, which creates/updates/deletes the relevant components. Similar to what we already have on OCP. There's a gap about how to retrieve the `containerruntimeconfig` object which is needed by the controller and is not accessible in the hosted control plane namespace. This will be handle on a separate PR. Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: stub implementation for status writer interface status reporting is not supported on hypershift yet. we provide a fake implementation in order to conforms the interface. Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: check if in hypershift first Checking the feature gate first will result with an error on hypershift since it's not yet supported. Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: add management client Adding a management client to be used on a hypershift platform. Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: configure controller Add the necessary configuration for the controller, so it would be able to run on a hypershift platform. 1. It needs to configure predicates for ConfigMaps instead of actual objects. 2. It needs to setup different clients for the management cluster and hosted cluster. Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: generelize reconciliation loop Modify the reconciliation flow so it could fit for both HCP and OCP. Signed-off-by: Talor Itzhak <[email protected]> * e2e:config: adapt suite for hypershift Adding the relevant code for configuring performanceProfile over hypershift Signed-off-by: Talor Itzhak <[email protected]> * hypershift:client: do not assign to nil map Signed-off-by: Talor Itzhak <[email protected]> * hypershift:client: return error when configMap has invalid data state Signed-off-by: Talor Itzhak <[email protected]> * pao:hypershift: move label validation to helper function Signed-off-by: Talor Itzhak <[email protected]> * vendor: bump deps Bump needed for handling hypershift APIs. This is the output formatted and generated by the \`go mod tidy\` Signed-off-by: Talor Itzhak <[email protected]> * vendor:featuregate: adopt feature gate api changes The package that holds featuregate geatures has changed in the last vendor bump. This commit uses the new paths. Signed-off-by: Talor Itzhak <[email protected]> * pao:log: small refining - Move logs to V(4) - Fix typos - Remove redundant spacing - Consistent HyperShift naming Signed-off-by: Talor Itzhak <[email protected]> --------- Signed-off-by: Talor Itzhak <[email protected]>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024

openshift-ci bot requested review from dagrayvid and yanirq May 9, 2024 14:11

rbaturov reviewed May 12, 2024

View reviewed changes

pkg/performanceprofile/controller/performanceprofile/hypershift/components/handler.go Outdated Show resolved Hide resolved

rbaturov reviewed May 12, 2024

View reviewed changes

pkg/performanceprofile/controller/performanceprofile/hypershift/status/status.go Outdated Show resolved Hide resolved

rbaturov reviewed May 13, 2024

View reviewed changes

pkg/performanceprofile/controller/performanceprofile_controller.go Show resolved Hide resolved

Tal-or force-pushed the pao_adoption_phase3 branch from a72d1dd to 9195346 Compare May 15, 2024 08:23

Tal-or force-pushed the pao_adoption_phase3 branch from 9195346 to 5e01e76 Compare May 15, 2024 08:47

Tal-or force-pushed the pao_adoption_phase3 branch from 5e01e76 to 833c724 Compare May 16, 2024 09:22

Tal-or mentioned this pull request May 16, 2024

WIP: e2e: adapt config suite for hypershift #1020

Closed

Tal-or force-pushed the pao_adoption_phase3 branch from 833c724 to d150863 Compare May 22, 2024 08:29

Tal-or force-pushed the pao_adoption_phase3 branch from d150863 to 3849355 Compare May 22, 2024 13:17

This comment was marked as off-topic.

Sign in to view

Tal-or commented May 22, 2024

View reviewed changes

pkg/performanceprofile/controller/performanceprofile/hypershift/hypershift.go Show resolved Hide resolved

Tal-or force-pushed the pao_adoption_phase3 branch 2 times, most recently from 445e82f to 4c5cbe5 Compare May 28, 2024 06:29

Tal-or force-pushed the pao_adoption_phase3 branch from 4c5cbe5 to 8388f77 Compare May 29, 2024 11:58

Tal-or changed the title ~~WIP: CNF-11559: [Part 3/3] Hypershift PAO adoption~~ CNF-11559: [Part 3/3] Hypershift PAO adoption May 29, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2024

Tal-or added 12 commits June 6, 2024 08:19

pao:hypershift: stub implementation for status writer interface

fab5851

status reporting is not supported on hypershift yet. we provide a fake implementation in order to conforms the interface. Signed-off-by: Talor Itzhak <[email protected]>

pao:hypershift: check if in hypershift first

916667c

Checking the feature gate first will result with an error on hypershift since it's not yet supported. Signed-off-by: Talor Itzhak <[email protected]>

pao:hypershift: add management client

48a568e

Adding a management client to be used on a hypershift platform. Signed-off-by: Talor Itzhak <[email protected]>

pao:hypershift: generelize reconciliation loop

179db3d

Modify the reconciliation flow so it could fit for both HCP and OCP. Signed-off-by: Talor Itzhak <[email protected]>

e2e:config: adapt suite for hypershift

fa76afb

Adding the relevant code for configuring performanceProfile over hypershift Signed-off-by: Talor Itzhak <[email protected]>

hypershift:client: do not assign to nil map

c9bedb3

Signed-off-by: Talor Itzhak <[email protected]>

hypershift:client: return error when configMap has invalid data state

91ec079

Signed-off-by: Talor Itzhak <[email protected]>

pao:hypershift: move label validation to helper function

e924c68

Signed-off-by: Talor Itzhak <[email protected]>

vendor: bump deps

c4e5d88

Bump needed for handling hypershift APIs. This is the output formatted and generated by the \`go mod tidy\` Signed-off-by: Talor Itzhak <[email protected]>

vendor:featuregate: adopt feature gate api changes

dd75be3

The package that holds featuregate geatures has changed in the last vendor bump. This commit uses the new paths. Signed-off-by: Talor Itzhak <[email protected]>

pao:log: small refining

2391f85

- Move logs to V(4) - Fix typos - Remove redundant spacing - Consistent HyperShift naming Signed-off-by: Talor Itzhak <[email protected]>

Tal-or force-pushed the pao_adoption_phase3 branch from 7ef0009 to 2391f85 Compare June 6, 2024 05:21

ffromani reviewed Jun 7, 2024

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 7, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2024

openshift-merge-bot bot merged commit 4d6cb12 into openshift:master Jun 9, 2024
16 checks passed

Tal-or deleted the pao_adoption_phase3 branch June 9, 2024 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

Tal-or commented May 9, 2024 •

edited

Loading

openshift-ci-robot commented May 9, 2024 •

edited by openshift-ci bot

Loading

Tal-or commented May 12, 2024

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

Tal-or commented May 15, 2024

openshift-ci-robot commented May 16, 2024 •

edited by openshift-ci bot

Loading

Tal-or commented May 22, 2024

This comment was marked as off-topic.

Tal-or commented May 28, 2024

Tal-or commented May 28, 2024

Tal-or commented Jun 6, 2024

jmencak commented Jun 7, 2024

Tal-or commented Jun 7, 2024

ffromani left a comment

ffromani commented Jun 7, 2024

ffromani commented Jun 7, 2024

yanirq commented Jun 9, 2024

openshift-ci bot commented Jun 9, 2024

openshift-ci bot commented Jun 9, 2024

openshift-bot commented Jun 10, 2024

CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

Conversation

Tal-or commented May 9, 2024 • edited Loading

openshift-ci-robot commented May 9, 2024 • edited by openshift-ci bot Loading

Tal-or commented May 12, 2024

openshift-ci-robot commented May 15, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented May 15, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented May 15, 2024 • edited by openshift-ci bot Loading

Tal-or commented May 15, 2024

openshift-ci-robot commented May 16, 2024 • edited by openshift-ci bot Loading

Tal-or commented May 22, 2024

This comment was marked as off-topic.

Tal-or commented May 28, 2024

Tal-or commented May 28, 2024

Tal-or commented Jun 6, 2024

jmencak commented Jun 7, 2024

Tal-or commented Jun 7, 2024

ffromani left a comment

Choose a reason for hiding this comment

ffromani commented Jun 7, 2024

ffromani commented Jun 7, 2024

yanirq commented Jun 9, 2024

openshift-ci bot commented Jun 9, 2024

openshift-ci bot commented Jun 9, 2024

openshift-bot commented Jun 10, 2024

Tal-or commented May 9, 2024 •

edited

Loading

openshift-ci-robot commented May 9, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 15, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 16, 2024 •

edited by openshift-ci bot

Loading