Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PAO adaptation to Hypershift proposal #947

Closed

Conversation

jlojosnegros
Copy link
Contributor

This is the proposal to adapt Performance Profile Controller to Hypershift.

I have created this pull request for sake of discussion and comments. it is not intended to be merged.

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlojosnegros
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval by writing /assign @marsik in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Sep 14, 2022

Pull Request Test Coverage Report for Build 2630

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.463%

Totals Coverage Status
Change from base Build 2616: 0.0%
Covered Lines: 1644
Relevant Lines: 2719

💛 - Coveralls

Copy link

@dagrayvid dagrayvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlojosnegros. Over all this seems in-line with how I imagined PAO would function in HyperShift. I left a few comments for discussion.

docs/enhancements/hypershift-adaptation.md Outdated Show resolved Hide resolved
docs/enhancements/hypershift-adaptation.md Outdated Show resolved Hide resolved
docs/enhancements/hypershift-adaptation.md Show resolved Hide resolved
@jlojosnegros
Copy link
Contributor Author

enhancement open: openshift/enhancements#1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants