-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PAO adaptation to Hypershift proposal #947
[WIP] PAO adaptation to Hypershift proposal #947
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlojosnegros The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 2630
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jlojosnegros. Over all this seems in-line with how I imagined PAO would function in HyperShift. I left a few comments for discussion.
Avoid to create a new field in NodePool API just to reference PerformanceProfiles configurations
61a0ed7
to
2bc7129
Compare
enhancement open: openshift/enhancements#1244 |
This is the proposal to adapt Performance Profile Controller to Hypershift.
I have created this pull request for sake of discussion and comments. it is not intended to be merged.
/hold