Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le #188
Conversation
…90x/ppc64le Similar to dmacvicar/terraform-provider-libvirt#718 The method of mimicking what Openstack does for injecting ignition config works for images which have the provider as Openstack because ignition recognizes the platform and knows it has to get the ignition config from the config drive. For QEMU images, ignition supports getting the config from the firmware config device which is not supported by ppc64 and s390x. The workaround we have used thus far is to use the Openstack image on the QEMU platform but have this provider create the iso containing the ignition config. There was a discussion in ignition (coreos/ignition#928) to have a more QEMU based method of injecting ignition config and it was decided to use a virtio-blk device with a serial of ignition which ignition can recognize. This was mainly because with external devices, it is hard to tell if there is an issue with the device or if the kernel has not detected it yet if it has a long discovery phase. This PR reverts the ISO method used by Openstack and just creates a virtio-blk device through the QEMU command line options. Reference PR which supports ignition fetching through virtio-blk for QEMU: coreos/ignition#936
Prashanth684
force-pushed
the
capl-virtio
branch
from
fcb260a to
614dbb3
Compare
|
/cc @crawford |
|
/lgtm |
|
/retest |
|
/cherry-pick release-4.4 |
|
@Prashanth684: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-libvirt |
|
/approve |
|
/retest |
|
/test e2e-libvirt |
|
The |
|
/test e2e-libvirt |
3 similar comments
|
/test e2e-libvirt |
|
/test e2e-libvirt |
|
/test e2e-libvirt |
|
/retest |
|
Let’s try this again, now that openshift/release#8592 has merged. /test e2e-libvirt |
|
@Prashanth684: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
From the failure:
/test e2e-libvirt |
|
/retitle Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@Prashanth684: This pull request references Bugzilla bug 1828961, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@Prashanth684: This pull request references Bugzilla bug 1828961, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
crawford
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: crawford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Prashanth684: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-libvirt#188. Bugzilla bug 1828961 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Prashanth684: new pull request created: #191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Similar to dmacvicar/terraform-provider-libvirt#718
The method of mimicking what Openstack does for injecting ignition config works for
images which have the provider as Openstack because ignition recognizes the platform
and knows it has to get the ignition config from the config drive. For QEMU images, ignition
supports getting the config from the firmware config device which is not supported by ppc64
and s390x.
The workaround we have used thus far is to use the Openstack image on the QEMU platform but have this provider create the iso containing the ignition config. There was a discussion in ignition
(coreos/ignition#928) to have a more QEMU based method of injecting ignition config and it was decided to use a virtio-blk device with a serial of ignition which ignition can recognize. This was mainly because with external devices, it is hard to tell if there is an issue with the device or if the kernel has not detected it yet if it has a long discovery phase.
This PR reverts the ISO method used by Openstack and just creates a virtio-blk device through the QEMU command line options.
Reference PR which supports ignition fetching through virtio-blk for QEMU: coreos/ignition#936