Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator: update libvirt job #8592

Merged
merged 1 commit into from
Apr 28, 2020
Merged

ci-operator: update libvirt job #8592

merged 1 commit into from
Apr 28, 2020

Conversation

crawford
Copy link
Contributor

@crawford crawford commented Apr 28, 2020 •
edited
Loading

The e2e-libvirt job has been broken for cluster-api-provider-libvirt a
little while with the following:

error: suite "files" does not contain any tests

I just copied the tests over from the installer's job. This should be
cleaned up into a template so that these definitions don't fall out of
sync again.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020
@crawford
ci-operator: update libvirt job
46469cd 
The e2e-libvirt job has been broken for cluster-api-provider-libvirt a
little while with the following:

    error: suite "files" does not contain any tests

I just copied the tests over from the installer's job. This should be
cleaned up into a template so that these definitions don't fall out of
sync again.
@crawford crawford changed the title WIP: testing libvirt ci-operator: update libvirt job Apr 28, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020
@crawford
Copy link
Contributor Author

/retest

@praveenkumar
Copy link
Contributor

/lgtm

looks like now there is no such test like [Conformance][Area:Networking][Feature:Router] The HAProxy router should override the route host for overridden domains with a custom value [Suite:openshift/conformance/parallel/minimal] .
Also test file suppose to have around 127 test case and only 33 are valid now and run https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_release/8592/rehearse-8592-pull-ci-openshift-cluster-api-provider-libvirt-master-e2e-libvirt/3/artifacts/e2e-libvirt/container-logs/test.log

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2020
@praveenkumar
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4b7d8bb into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@crawford: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-api-provider-libvirt-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-libvirt/openshift-cluster-api-provider-libvirt-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-libvirt-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-libvirt/openshift-cluster-api-provider-libvirt-master-presubmits.yaml

In response to this:

The e2e-libvirt job has been broken for cluster-api-provider-libvirt a
little while with the following:

error: suite "files" does not contain any tests

I just copied the tests over from the installer's job. This should be
cleaned up into a template so that these definitions don't fall out of
sync again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford crawford deleted the libvirt branch April 28, 2020 12:12
@crawford crawford mentioned this pull request Apr 28, 2020
Merged
praveenkumar added a commit to praveenkumar/release that referenced this pull request Apr 30, 2020
@praveenkumar
Update libvirt job for 4.4 release branch
5d4d330 
The e2e-libvirt job has been broken for cluster-api-provider-libvirt for
4.4 release branch with the following:

    error: suite "files" does not contain any tests

This is kind of in sync with openshift#8592
andymcc added a commit to andymcc/release that referenced this pull request May 15, 2020
@andymcc
Update libvirt job for 4.4 release branch
ccb1489 
The e2e-libvirt job has been broken for cluster-api-provider-libvirt for
4.4 release branch with the following:

    error: suite "files" does not contain any tests

This PR updates the tests used in openshift#8592 to use the same tests named
correctly for 4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

@cfergeau cfergeau Awaiting requested review from cfergeau

Assignees

@praveenkumar praveenkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crawford @praveenkumar @openshift-ci-robot @openshift-merge-robot