Bug 1812237: libvirt installer template: increase teardown timeout, add setup-fail marker #7568
Conversation
openshift-ci-robot
added
the
size/S
|
In general LGTM. I will wait for tests/give others a chance to review. Is the problem that in the case of setup failure, the pods were hitting 4 hour time limit and teardown was never invoked? |
yes, that's the issue - I'm not sure this PR fixes the issue - the scripts were very outdated, have to update them to be able to test this: ironcladlou/openshift4-libvirt-gcp#25 /hold |
openshift-ci-robot
added
the
do-not-merge/hold
I agree if we can make those scripts as part of openshift repo, it will get bit more attention and managed properly. |
ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
Outdated
Show resolved
Hide resolved
sallyom
force-pushed
the
bz1812237
branch
5 times, most recently
from
da0516f to
f5a6964
Compare
openshift-ci-robot
added
size/L
sallyom
force-pushed
the
bz1812237
branch
2 times, most recently
from
8c188ad to
f07c7f2
Compare
openshift-ci-robot
added
size/S
|
/hold cancel |
openshift-ci-robot
added
size/M
|
/lgtm |
|
soo close to complete install |
|
/retest |
ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
Show resolved
Hide resolved
Setting --subnet-mode=auto is wasteful in this case because auto sets a subnet in every region. Setting --subnet-mode=custom configures a subnet within a single region.
sallyom
force-pushed
the
bz1812237
branch
2 times, most recently
from
f18912f to
c9a0798
Compare
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
1 similar comment
|
/retest |
|
@sallyom Awesome work! /lgtm |
|
/assign @smarterclayton |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, jstuever, praveenkumar, sallyom, zeenix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sallyom: All pull requests linked via external trackers have merged: openshift/release#7568. Bugzilla bug 1812237 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sallyom: Updated the following 7 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've updated CI scripts and images:
I've pulled in this, too: #7572
@smarterclayton @ironcladlou As more teams are depending on libvirt CI, it makes sense to reconsider pulling the openshift4-libvirt-gcp repo into openshift, so this doesn't happen again - the scripts are way outdated - there's no chance of libvirt CI passing with them as/is. Once they are updated, that repo is very useful for anyone wanting to spin up a single gcp instance nested libvirt dev cluster. Solves the issue of not able to/not wanting to run a libvirt cluster on your own system.
/cc @praveenkumar