update how to set libvirt master memory add wait-for installer-complete #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
rhel8
branch
2 times, most recently
from
3a9f367 to
0e9ee53
Compare
praveenkumar
reviewed
Apr 6, 2020
create-gcp-resources.sh
Outdated
| @@ -40,6 +44,11 @@ gcloud compute instances create "${INSTANCE}" \ | |||
| --network "${INSTANCE}" \ | |||
| --subnet "${INSTANCE}" | |||
|
|
|||
| # pause for ssh for a few seconds | |||
| echo pause for 10s before copying the pull-secret | |||
| sleep 10s | |||
There was a problem hiding this comment.
@sallyom Are we sure that within 10s the ssh command is available for use? Can we poll with ssh command with a timeout around 30-40sec?
There was a problem hiding this comment.
yes, I was meaning to update that, you're right, this last cmd fails even w/ the 10s - i'll update it
| openshift-install create cluster --log-level=debug --dir="$CLUSTER_DIR" | ||
| # Add master memory to 12 GB | ||
| # This is only valid for openshift 4.3 onwards | ||
| yq write --inplace ${CLUSTER_DIR}/openshift/99_openshift-cluster-api_master-machines-0.yaml spec.providerSpec.value[domainMemory] 14336 |
1) set libvirt master memory via machineconfigs 2) add wait-for installer-complete 3) ensure OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE is set when running create-cluster 4) retry with scp copy in create-gcp-resources script 5) pretty colors in create/teardown scripts, README update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @praveenkumar
/cc @ironcladlou
TF_VAR_libvirt_master_memory(see here: https://github.com/code-ready/snc/blob/master/snc.sh#L236-L238)openshift-install wait-for install-completeto the create-cluster script