ARMOCP-417: enable arm64 for agent installer

[jeffdyoung]

Translate arm64-> aarch64 in instances where we reference rhcos (should mirror x86_64 -> amd64 mapping)
In parallel with openshift-installer change for agent installer: openshift/installer#6401

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment (dev-scripts needs additional work to support arm)
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  Manually created agent.iso and installed OCP with arm64 BM HW in our RDU2 lab
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[codecov]

Codecov Report

Merging #4441 (6d466b5) into master (194fafb) will decrease coverage by 0.01%.
The diff coverage is 47.36%.

❗ Current head 6d466b5 differs from pull request most recent head 17d6603. Consider uploading reports for the commit 17d6603 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4441      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.01%     
==========================================
  Files         203      203              
  Lines       30300    30312      +12     
==========================================
+ Hits        20471    20477       +6     
- Misses       8021     8027       +6     
  Partials     1808     1808              

Impacted Files	Coverage Δ
internal/common/common.go	30.76% <0.00%> (-1.32%)	⬇️
internal/versions/osimages.go	90.99% <0.00%> (-1.67%)	⬇️
internal/bminventory/inventory.go	69.66% <100.00%> (+<0.01%)	⬆️
internal/oc/release.go	72.31% <100.00%> (+1.29%)	⬆️
internal/versions/versions.go	87.87% <100.00%> (+0.30%)	⬆️

[jeffdyoung]

/retest

[carbonin]

Do we think we need to normalize these?

This is comparing the architecture in the infraEnv CR with the one in the preprovisioningimage (detected by ironic in some way).

Although I don't think this PR will change either of those as one is provided by the user and the other is provided by ironic so maybe it's fine (or at least as fine as it was before).

[jeffdyoung]

Do we think we need to normalize these?

I haven't hit this in my local testing w/agent installer. FWIW, my first attempts was normalizing all comparisons, didn't work and was kinda messy. Normalizing the inputs seems to be the best route.

This is comparing the architecture in the infraEnv CR with the one in the preprovisioningimage (detected by ironic in some way).

Although I don't think this PR will change either of those as one is provided by the user and the other is provided by ironic so maybe it's fine (or at least as fine as it was before).

[carbonin]

I haven't hit this in my local testing w/agent installer.

You wouldn't, this is a ZTP-specific section of the code, but I think we can leave it for now.

Looks like you'll need to address the subsystem test failure though.

[openshift-ci]

@jeffdyoung: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-capi	49e395d	link	false	/test edge-e2e-metal-assisted-capi
ci/prow/edge-e2e-metal-assisted-static-ip-suite	00ec0bd	link	false	/test edge-e2e-metal-assisted-static-ip-suite

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, jeffdyoung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carbonin]

FWIW this also resolves https://issues.redhat.com/browse/MGMT-13386