WIP: NO-JIRA: Validate the CPU architectures set by users in the CRs

[aleskandro]

There is an inconsistency about the name of the architecture to use in the InfraEnv and other CRDs using the OSImage object. Users can easily provide a "wrong" value for the CPUArchitecture fields in such CRs and no error would arise at creation time as they are not validated, making it harder for the user to debug and understand how to proceed with their deployment.

This commit adds validation for the architecture field among the values in the set {arm64, ppc64le, s390x, x86_64}

Related to #4441 openshift/release#60815

[openshift-ci-robot]

@aleskandro: This pull request explicitly references no jira issue.

In response to this:

There is an inconsistency about the name of the architecture to use in the InfraEnv and other CRDs using the OSImage object. Users can easily provide a different string for the CPUArchitecture fields in such CRs and no error would arise from them as they are not validated, making it harder for the user to debug and understand how to proceed with their deployment.

This commit adds validation for the architecture field among the values in the set {arm64, ppc64le, s390x, x86_64}

Related to #4441

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aleskandro
Once this PR has been reviewed and has the lgtm label, please assign paul-maidment for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aleskandro]

/cc @jeffdyoung

i'm not sure these are the expected values, but having at least some validation would mitigate the incosistencies in the architecture naming

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (dd3c75d) to head (904a104).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7224      +/-   ##
==========================================
- Coverage   67.90%   67.89%   -0.01%     
==========================================
  Files         298      298              
  Lines       40710    40710              
==========================================
- Hits        27643    27640       -3     
- Misses      10590    10592       +2     
- Partials     2477     2478       +1     

see 2 files with indirect coverage changes

[openshift-ci]

@aleskandro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	904a104	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/edge-verify-generated-code	904a104	link	true	/test edge-verify-generated-code

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.