Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARMOCP-417: enable arm64 for agent installer #6401

Merged
merged 1 commit into from
Mar 2, 2023
Merged

ARMOCP-417: enable arm64 for agent installer #6401

merged 1 commit into from
Mar 2, 2023

Conversation

jeffdyoung
Copy link
Contributor

@jeffdyoung jeffdyoung commented Sep 22, 2022 •
edited
Loading

Enable arm64 iso builds for agent installer based on the control plane architecture set in install-config.yaml.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@jeffdyoung
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2022
cs-zhang
cs-zhang suggested changes Sep 22, 2022
View reviewed changes
pkg/asset/agent/manifests/infraenv.go Outdated Show resolved Hide resolved
pkg/asset/agent/image/baseiso.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2022
@jeffdyoung jeffdyoung changed the title [WIP] enable arm64 for agent installer ARMOCP-417: enable arm64 for agent installer Sep 26, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022
@jeffdyoung jeffdyoung mentioned this pull request Sep 26, 2022
Merged
19 tasks
@jeffdyoung
Copy link
Contributor Author

/retest

zaneb
zaneb reviewed Sep 30, 2022
View reviewed changes
pkg/asset/agent/image/baseiso.go Outdated Show resolved Hide resolved
pkg/asset/agent/image/ignition.go Outdated Show resolved Hide resolved
pkg/asset/agent/image/baseiso.go Outdated Show resolved Hide resolved
pkg/asset/agent/image/oc.go Outdated Show resolved Hide resolved
pkg/asset/agent/image/oc.go Outdated Show resolved Hide resolved
pkg/asset/agent/manifests/common.go Outdated Show resolved Hide resolved
@zaneb zaneb mentioned this pull request Sep 30, 2022
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022
@jeffdyoung jeffdyoung force-pushed the arm-agent-installer branch from 2ea3da2 to 1b42c8e Compare January 5, 2023 14:53
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2023
@jeffdyoung jeffdyoung changed the title ARMOCP-417: enable arm64 for agent installer WIP ARMOCP-417: enable arm64 for agent installer Jan 5, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
@jeffdyoung jeffdyoung changed the title WIP ARMOCP-417: enable arm64 for agent installer [WIP] ARMOCP-417: enable arm64 for agent installer Jan 5, 2023
@jeffdyoung jeffdyoung force-pushed the arm-agent-installer branch 2 times, most recently from e317567 to 1ec176a Compare January 17, 2023 14:28
@jeffdyoung jeffdyoung changed the title [WIP] ARMOCP-417: enable arm64 for agent installer ARMOCP-417: enable arm64 for agent installer Jan 17, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
zaneb
zaneb reviewed Feb 19, 2023
View reviewed changes
pkg/types/machinepools.go Outdated Show resolved Hide resolved
pkg/asset/agent/installconfig.go Show resolved Hide resolved
pkg/asset/agent/manifests/infraenv.go Outdated Show resolved Hide resolved
pkg/asset/agent/manifests/infraenv.go Show resolved Hide resolved
pkg/asset/agent/image/baseiso.go Show resolved Hide resolved
@jeffdyoung jeffdyoung force-pushed the arm-agent-installer branch 3 times, most recently from 6a734f0 to 89d3f73 Compare February 20, 2023 22:15
@jeffdyoung
Copy link
Contributor Author

/retest

@jeffdyoung jeffdyoung requested a review from zaneb February 21, 2023 13:48
@jeffdyoung jeffdyoung force-pushed the arm-agent-installer branch 2 times, most recently from 505e87b to 3578f66 Compare February 23, 2023 20:22
@jeffdyoung
Copy link
Contributor Author

/retest

1 similar comment
@jeffdyoung
Copy link
Contributor Author

/retest

@jeffdyoung jeffdyoung requested a review from zaneb February 26, 2023 23:40
@zaneb
Copy link
Member

zaneb commented Feb 28, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@jeffdyoung
Copy link
Contributor Author

/retest

1 similar comment
@jeffdyoung
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@jeffdyoung: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-ovn-upgrade c7808a7fb0f7020f79fc3350ffe1fb7b24767d10 link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/e2e-agent-mce 2ea3da22653d00cebd6fb41fe4a945e21c5b4908 link false /test e2e-agent-mce
ci/prow/e2e-agent-compact 2ea3da22653d00cebd6fb41fe4a945e21c5b4908 link true /test e2e-agent-compact
ci/prow/e2e-azure-ovn 1b42c8e0960b39efec940c6cdf6c92f8de13a290 link true /test e2e-azure-ovn
ci/prow/e2e-ovirt-sdn 1b42c8e0960b39efec940c6cdf6c92f8de13a290 link false /test e2e-ovirt-sdn
ci/prow/e2e-libvirt 1b42c8e0960b39efec940c6cdf6c92f8de13a290 link false /test e2e-libvirt
ci/prow/e2e-aws-ovn-disruptive e700686d4f835a2b9848f4a08cb83358e2f16c50 link false /test e2e-aws-ovn-disruptive
ci/prow/okd-scos-e2e-aws-ovn 1fc134b link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade 1fc134b link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade 1fc134b link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeffdyoung
Copy link
Contributor Author

Lastly @zaneb @andfasano these 3 CI jobs seem to be flaky and are failing unrelated to this pr:
okd-e2e-aws-ovn-upgrade
okd-scos-e2e-aws-ovn
okd-scos-e2e-aws-upgrade

Are you guys ok with an override?

@andfasano
Copy link
Contributor

Lastly @zaneb @andfasano these 3 CI jobs seem to be flaky and are failing unrelated to this pr: okd-e2e-aws-ovn-upgrade okd-scos-e2e-aws-ovn okd-scos-e2e-aws-upgrade

Are you guys ok with an override?

Sounds fine for me, but cannot override them cc @patrickdillon

@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@patrickdillon
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit 78e72e5 into openshift:master Mar 2, 2023
@jeffdyoung jeffdyoung mentioned this pull request Mar 7, 2023
Merged
@jeffdyoung jeffdyoung deleted the arm-agent-installer branch July 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie bfournie left review comments

@cs-zhang cs-zhang cs-zhang requested changes

@andfasano andfasano andfasano left review comments

@rwsu rwsu rwsu requested changes

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@bfournie bfournie

@andfasano andfasano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jeffdyoung @bfournie @openshift-ci-robot @zaneb @andfasano @patrickdillon @rwsu @cs-zhang @openshift-merge-robot