Refactors reRequestAuthentication to call notifyIpAuthFailureListener before sending the response to the channel #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isteners to be called before sending back the channel response Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3411 +/- ##
============================================
+ Coverage 64.23% 64.27% +0.04%
Complexity 3491 3491
============================================
Files 264 264
Lines 20152 20152
Branches 3363 3364 +1
============================================
+ Hits 12944 12953 +9
+ Misses 5527 5526 -1
+ Partials 1681 1673 -8
|
…bled Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
refactor-rereq-authentication
branch
from
1eb4ffc to
fa46d36
Compare
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Signed-off-by: Darshit Chanpura <[email protected]>
cwperks
reviewed
Sep 28, 2023
cwperks
reviewed
Sep 28, 2023
There was a problem hiding this comment.
Thank you @DarshitChanpura. Overall this looks like a really good change to me and I really like reducing the number of channel.sendResponses because I really think there should just be a single place for that call.
The SAML flow is pretty confusing, but that pre-exists this PR.
Completely agree. SAML auth flow is slightly confusing and was tricky to navigate with the fix. |
cwperks
approved these changes
Oct 2, 2023
RyanL1997
approved these changes
Oct 3, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3411-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7924da13a57ecbf3352d84e6d020012723b81fa1
# Push it to GitHub
git push --set-upstream origin backport/backport-3411-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
DarshitChanpura
added a commit
to DarshitChanpura/security
that referenced
this pull request
Oct 3, 2023
… before sending the response to the channel (opensearch-project#3411) Prior to this change, the ip auth failure listener was not called upon challengeAuthenticator check invocation, which caused AddressBasedRateLimiter to not be invoked. With this change AddressBasedRateLimiter will be invoked upon multiple wrong requests from an ip. Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 7924da1)
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, the ip auth failure listener was not called upon challengeAuthenticator check invocation, which caused AddressBasedRateLimiter to not be invoked. With this change AddressBasedRateLimiter will be invoked upon multiple wrong requests from an ip
Issues Resolved
Testing
Integration Testing (Adds a new test to verify the change)
When cluster was setup with Basic http challenge:
Before:
After:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.