[Backport 2.x] Refactors reRequestAuthentication to call notifyIpAuthFailureListener before sending the response to the channel (#3411) #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before sending the response to the channel (opensearch-project#3411) Prior to this change, the ip auth failure listener was not called upon challengeAuthenticator check invocation, which caused AddressBasedRateLimiter to not be invoked. With this change AddressBasedRateLimiter will be invoked upon multiple wrong requests from an ip. Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 7924da1)
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
DarshitChanpura
changed the title
Codecov Report
@@ Coverage Diff @@
## 2.x #3445 +/- ##
============================================
+ Coverage 64.58% 64.62% +0.03%
Complexity 3510 3510
============================================
Files 260 260
Lines 19715 19715
Branches 3307 3308 +1
============================================
+ Hits 12733 12740 +7
+ Misses 5350 5343 -7
Partials 1632 1632
|
cwperks
previously approved these changes
Oct 3, 2023
willyborankin
previously approved these changes
Oct 3, 2023
DarshitChanpura
dismissed stale reviews from willyborankin and cwperks
via
4db1635
|
@cwperks @willyborankin Mind reviewing this again? |
willyborankin
approved these changes
Oct 3, 2023
cwperks
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3411
(cherry picked from commit 7924da1)
Manual Backport is required because: BackendRegistry had conflicts due to OnBehalfOfAuthenticator not being present in 2.x but it exists in main.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.