Skip to content

Commit

Permalink
Cleans up some left-over comments
Browse files Browse the repository at this point in the history
Signed-off-by: Darshit Chanpura <[email protected]>
  • Loading branch information
DarshitChanpura committed Sep 27, 2023
1 parent fa46d36 commit 9185eab
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ && isBlocked(((InetSocketAddress) request.getHttpChannel().getRemoteAddress()).g
if (isTraceEnabled) {
log.trace("No 'Authorization' header, send 401 and 'WWW-Authenticate Basic'");

Check warning on line 288 in src/main/java/org/opensearch/security/auth/BackendRegistry.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/security/auth/BackendRegistry.java#L288

Added line #L288 was not covered by tests
}
notifyIpAuthFailureListeners(request, authCredentials); // is this needed here??
notifyIpAuthFailureListeners(request, authCredentials);
channel.sendResponse(restResponse);
return false;
}
Expand All @@ -306,7 +306,7 @@ && isBlocked(((InetSocketAddress) request.getHttpChannel().getRemoteAddress()).g
// credentials found in request but we need another client challenge
if (restResponse != null) {
// auditLog.logFailedLogin(ac.getUsername()+" <incomplete>", request); --noauditlog
notifyIpAuthFailureListeners(request, ac); // is this needed here??
notifyIpAuthFailureListeners(request, ac);
channel.sendResponse(restResponse);

Check warning on line 310 in src/main/java/org/opensearch/security/auth/BackendRegistry.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/security/auth/BackendRegistry.java#L309-L310

Added lines #L309 - L310 were not covered by tests
return false;
} else {
Expand Down

0 comments on commit 9185eab

Please sign in to comment.