Match version of zstd-jni from core

[cwperks]

Description

Currently ./gradlew assemble is failing for the security plugin due to the addition of zstd-jni in core which the security plugin already has a runtime dependency on. This PR uses the version from core's version.properties to ensure there is a matching version.

Related PR: opensearch-project/OpenSearch#2996

./gradlew assemble is failing with the following error:

Execution failed for task ':bundlePlugin'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Conflict(s) found for the following module(s):
       - com.github.luben:zstd-jni between versions 1.5.5-3 and ${versions.zstd}
     Run with:
         --scan or
         :dependencyInsight --configuration runtimeClasspath --dependency com.github.luben:zstd-jni
     to get more insight on how to solve the conflict.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[reta]

@cwperks I haven't checked by do you happen to know why ZSTD is needed for security plugin? thank you.

[RyanL1997]

Hey @reta, thank you for checking this up~ I think the one is related to the core changes about the snapshot compression. I think we dont rely on this for any part of our code, but we do have this related to the task :bundlePlugin of build in build.gradle.

[cwperks]

I'm not entirely sure, but it looks related to kafka.

This runtimeOnly dependency was added in the switch to the opensearch standard build.gradle file here: 03a224d

And it was upgraded once when kafka was upgraded: #2484

Kafka is one of the available sinks for audit logging.

I am taking a deeper look into what those runtimeOnly dependencies are in the build.gradle file.

[reta]

Thank you folks

[cwperks]

I believe its utilized here at runtime: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/auditlog/sink/KafkaSink.java#L75-L85

There's more details on the KafkaProducer from IBM here: https://developer.ibm.com/articles/benefits-compression-kafka-messaging/

[codecov]

Codecov Report

Merging #2832 (80d4c33) into main (76a5d7f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2832      +/-   ##
============================================
- Coverage     61.60%   61.56%   -0.04%     
+ Complexity     3414     3411       -3     
============================================
  Files           266      266              
  Lines         18917    18917              
  Branches       3303     3303              
============================================
- Hits          11653    11647       -6     
- Misses         5669     5670       +1     
- Partials       1595     1600       +5     

see 3 files with indirect coverage changes

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2832-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 abcb3a2124b3bb8f5b8bd81c83c3fb5ddc5edd50
# Push it to GitHub
git push --set-upstream origin backport/backport-2832-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2832-to-2.x.

[cwperks]

I'll create a manual backport