Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match version of zstd-jni from core #2832

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Match version of zstd-jni from core #2832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36e0ec
Match version of zstd-jni from core
cwperks Jun 2, 2023
80d4c33
Add zstd version from core to force resolutions section
cwperks Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ configurations {
force "io.netty:netty-transport:${versions.netty}"
force "io.netty:netty-transport-native-unix-common:${versions.netty}"
force "org.apache.bcel:bcel:6.6.0" // This line should be removed once Spotbugs is upgraded to 4.7.4
force "com.github.luben:zstd-jni:${versions.zstd}"
}
}

Expand Down Expand Up @@ -460,7 +461,7 @@ dependencies {
runtimeOnly 'com.fasterxml.woodstox:woodstox-core:6.4.0'
runtimeOnly 'org.apache.ws.xmlschema:xmlschema-core:2.2.5'
runtimeOnly 'org.apache.santuario:xmlsec:2.2.3'
runtimeOnly 'com.github.luben:zstd-jni:1.5.2-1'
runtimeOnly "com.github.luben:zstd-jni:${versions.zstd}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks I haven't checked by do you happen to know why ZSTD is needed for security plugin? thank you.

Copy link
Collaborator

@RyanL1997 RyanL1997 Jun 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @reta, thank you for checking this up~ I think the one is related to the core changes about the snapshot compression. I think we dont rely on this for any part of our code, but we do have this related to the task :bundlePlugin of build in build.gradle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure, but it looks related to kafka.

This runtimeOnly dependency was added in the switch to the opensearch standard build.gradle file here: 03a224d

And it was upgraded once when kafka was upgraded: #2484

Kafka is one of the available sinks for audit logging.

I am taking a deeper look into what those runtimeOnly dependencies are in the build.gradle file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you folks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe its utilized here at runtime: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/auditlog/sink/KafkaSink.java#L75-L85

There's more details on the KafkaProducer from IBM here: https://developer.ibm.com/articles/benefits-compression-kafka-messaging/

runtimeOnly 'org.checkerframework:checker-qual:3.5.0'
runtimeOnly "org.bouncycastle:bcpkix-jdk15on:${versions.bouncycastle}"

Expand Down