Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] added 404s #149

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[Backport 2.x] added 404s #149

merged 1 commit into from
Nov 11, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ecd582a from #146

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit ecd582a)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team November 11, 2022 02:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #149 (1823eee) into 2.x (22c06b0) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x     #149      +/-   ##
============================================
- Coverage     39.08%   39.04%   -0.05%     
- Complexity      882      884       +2     
============================================
  Files           176      176              
  Lines          6695     6711      +16     
  Branches        815      817       +2     
============================================
+ Hits           2617     2620       +3     
- Misses         3835     3850      +15     
+ Partials        243      241       -2     
Impacted Files Coverage Δ
...yanalytics/transport/TransportGetAlertsAction.java 0.00% <0.00%> (ø)
...nalytics/transport/TransportGetFindingsAction.java 0.00% <0.00%> (ø)
...ics/transport/TransportGetIndexMappingsAction.java 0.00% <0.00%> (ø)
...tics/transport/TransportGetMappingsViewAction.java 0.00% <0.00%> (ø)
.../transport/TransportUpdateIndexMappingsAction.java 0.00% <0.00%> (ø)
...lytics/transport/TransportValidateRulesAction.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 70.58% <0.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 134539e into 2.x Nov 11, 2022
@github-actions github-actions bot deleted the backport/backport-146-to-2.x branch November 11, 2022 02:30
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* Adjusted OSD version used by test workflows.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed env variable call.

Signed-off-by: AWSHurneyt <[email protected]>

* Revised comment to include github issue link.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…nsearch-project#128 (opensearch-project#147)

* [FEATURE] Create detector | Review and create step | Add detection rules count in the title opensearch-project#128

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjusted OSD version used by test workflows. (opensearch-project#149)

* Adjusted OSD version used by test workflows.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed env variable call.

Signed-off-by: AWSHurneyt <[email protected]>

* Revised comment to include github issue link.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* [FEATURE] Create detector | Review and create step | Add detection rules count in the title opensearch-project#128

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…rch-project#146)

* [FEATURE] Rules table | Change filter dropdown option to multiselect with OR condition opensearch-project#127

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjusted OSD version used by test workflows. (opensearch-project#149)

* Adjusted OSD version used by test workflows.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed env variable call.

Signed-off-by: AWSHurneyt <[email protected]>

* Revised comment to include github issue link.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* [FEATURE] Rules table | Change filter dropdown option to multiselect with OR condition opensearch-project#127

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…present (opensearch-project#136)

* disable notification option if no notif plugin

Signed-off-by: Aleksandar Djindjic <[email protected]>

* use fragment and &nbsp;

Signed-off-by: Aleksandar Djindjic <[email protected]>

* reference github issue in TODO

Signed-off-by: Aleksandar Djindjic <[email protected]>

* change console.error to teaster notifications

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add learn more link Resolves opensearch-project#137

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix console.error log

Signed-off-by: Aleksandar Djindjic <[email protected]>

* Adjusted OSD version used by test workflows. (opensearch-project#149)

* Adjusted OSD version used by test workflows.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed env variable call.

Signed-off-by: AWSHurneyt <[email protected]>

* Revised comment to include github issue link.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>

* use console.warn(s)

Signed-off-by: Aleksandar Djindjic <[email protected]>

* extract response logic to helper method

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants