[Backport 2.4] fixed GetFindings not searching all indices; fixed proper deletion of… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
#122) * fixed GetFindings not searching all indices; fixed proper deletion of old history indices Signed-off-by: Petar Dzepina <[email protected]> (cherry picked from commit 8dd1c9f)
eirsep
approved these changes
Nov 9, 2022
Codecov Report
@@ Coverage Diff @@
## 2.4 #136 +/- ##
============================================
+ Coverage 39.24% 39.29% +0.05%
- Complexity 882 891 +9
============================================
Files 176 176
Lines 6659 6683 +24
Branches 809 811 +2
============================================
+ Hits 2613 2626 +13
- Misses 3807 3816 +9
- Partials 239 241 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
…present (opensearch-project#136) * disable notification option if no notif plugin Signed-off-by: Aleksandar Djindjic <[email protected]> * use fragment and Signed-off-by: Aleksandar Djindjic <[email protected]> * reference github issue in TODO Signed-off-by: Aleksandar Djindjic <[email protected]> * change console.error to teaster notifications Signed-off-by: Aleksandar Djindjic <[email protected]> * add learn more link Resolves opensearch-project#137 Signed-off-by: Aleksandar Djindjic <[email protected]> * fix console.error log Signed-off-by: Aleksandar Djindjic <[email protected]> * Adjusted OSD version used by test workflows. (opensearch-project#149) * Adjusted OSD version used by test workflows. Signed-off-by: AWSHurneyt <[email protected]> * Fixed env variable call. Signed-off-by: AWSHurneyt <[email protected]> * Revised comment to include github issue link. Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> * use console.warn(s) Signed-off-by: Aleksandar Djindjic <[email protected]> * extract response logic to helper method Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8dd1c9f from #122