Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed aliases being returned in unmapped_index_fields #147

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Nov 11, 2022

Signed-off-by: Petar Dzepina [email protected]

Description

GetMappingsView API was returning aliases in "unmapped_index_fields" due to bug in field type filtering.

Issues Resolved

#171

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team November 11, 2022 00:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Merging #147 (1b04c86) into main (68231e9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #147      +/-   ##
============================================
+ Coverage     39.19%   39.20%   +0.01%     
  Complexity      891      891              
============================================
  Files           176      176              
  Lines          6702     6700       -2     
  Branches        815      815              
============================================
  Hits           2627     2627              
+ Misses         3834     3832       -2     
  Partials        241      241              
Impacted Files Coverage Δ
...ch/securityanalytics/mapper/MappingsTraverser.java 82.92% <100.00%> (+1.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 1c798dc into opensearch-project:main Dec 24, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 24, 2022
Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 1c798dc)
sbcd90 pushed a commit that referenced this pull request Dec 24, 2022
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…nsearch-project#128 (opensearch-project#147)

* [FEATURE] Create detector | Review and create step | Add detection rules count in the title opensearch-project#128

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjusted OSD version used by test workflows. (opensearch-project#149)

* Adjusted OSD version used by test workflows.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed env variable call.

Signed-off-by: AWSHurneyt <[email protected]>

* Revised comment to include github issue link.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* [FEATURE] Create detector | Review and create step | Add detection rules count in the title opensearch-project#128

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants