Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make tags hyperlinks to mitre attack web pages in detection rules (#… #698

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Sep 5, 2023

Description

Backport #692 to 2.x

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ensearch-project#692)

* made rule tags links to mitre attack webpage

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #698 (4adafbb) into 2.x (b6c3f58) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #698      +/-   ##
==========================================
- Coverage   31.28%   31.27%   -0.02%     
==========================================
  Files         150      150              
  Lines        4782     4787       +5     
  Branches      789      790       +1     
==========================================
+ Hits         1496     1497       +1     
- Misses       3108     3112       +4     
  Partials      178      178              

see 1 file with indirect coverage changes

@amsiglan
Copy link
Collaborator Author

amsiglan commented Sep 5, 2023

Failing test is unrelated to this change and fixed in PR #694

@amsiglan amsiglan merged commit df3272f into opensearch-project:2.x Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant