Updates to log types related UX #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov Report
@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 31.28% 31.48% +0.19%
==========================================
Files 150 150
Lines 4782 4812 +30
Branches 789 802 +13
==========================================
+ Hits 1496 1515 +19
- Misses 3108 3118 +10
- Partials 178 179 +1 |
…rom rules table in log type details Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
lezzago
reviewed
Sep 5, 2023
public/pages/Detectors/components/DetectorRulesView/DetectorRulesView.tsx
Show resolved
Hide resolved
1 task
lezzago
approved these changes
Sep 5, 2023
sbcd90
approved these changes
Sep 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
* updated log types related UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * added rule flyout in log type details page; removed log type column from rules table in log type details Signed-off-by: Amardeepsingh Siglani <[email protected]> * added search support Signed-off-by: Amardeepsingh Siglani <[email protected]> * using badge for severity in rules table Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed flaky test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 77410b0)
amsiglan
added a commit
that referenced
this pull request
Sep 6, 2023
* updated log types related UX Signed-off-by: Amardeepsingh Siglani <[email protected]> * added rule flyout in log type details page; removed log type column from rules table in log type details Signed-off-by: Amardeepsingh Siglani <[email protected]> * added search support Signed-off-by: Amardeepsingh Siglani <[email protected]> * using badge for severity in rules table Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed flaky test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 77410b0) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we have updated the UX related to log types to make below changes:
Sigmaused for pre-packaged detection rules toStandardCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.