Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tags hyperlinks to mitre attack web pages in detection rules #692

Merged

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Sep 1, 2023

Description

Information about tags with attack.T[0-9]+ pattern in a detection rule can be provided using the Mitre website. In this PR we detect such tags and make them hyperlinks so that users can learn more about the particular attack technique.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #692 (e2ceb9a) into main (96a96fb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   31.28%   31.27%   -0.02%     
==========================================
  Files         150      150              
  Lines        4782     4787       +5     
  Branches      789      790       +1     
==========================================
+ Hits         1496     1497       +1     
- Misses       3108     3112       +4     
  Partials      178      178              

see 1 file with indirect coverage changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit c26b693 into opensearch-project:main Sep 5, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-692-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c26b693341c582e57a1f07eebe6c676b3b90ec3d
# Push it to GitHub
git push --set-upstream origin backport/backport-692-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-692-to-2.x.

amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Sep 5, 2023
…ensearch-project#692)

* made rule tags links to mitre attack webpage

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Sep 5, 2023
…) (#698)

* made rule tags links to mitre attack webpage



* updated workflow file



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants