Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom log types] CRUD operations for log types #675

Merged
merged 12 commits into from
Jul 31, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

In this PR we have

  • Updated create flow for log types
  • Added Deletion confirmation modals
  • Added details page for log type with associated detection rules table

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #675 (7b62402) into main (ddd78a6) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   31.94%   31.37%   -0.57%     
==========================================
  Files         146      151       +5     
  Lines        4639     4771     +132     
  Branches      760      781      +21     
==========================================
+ Hits         1482     1497      +15     
- Misses       2979     3096     +117     
  Partials      178      178              

see 12 files with indirect coverage changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit dd1e88f into opensearch-project:main Jul 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-675-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd1e88f9281de1e076581434909105a21a0e558d
# Push it to GitHub
git push --set-upstream origin backport/backport-675-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-675-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-675-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd1e88f9281de1e076581434909105a21a0e558d
# Push it to GitHub
git push --set-upstream origin backport/backport-675-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-675-to-2.9.

amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jul 31, 2023
)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* implemented create, delete of log type

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* detection rules; delete modals added

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Jul 31, 2023
)

* log types table; details page with basic editing

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* implemented create, delete of log type

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* detection rules; delete modals added

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated cypress workflow

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated detector cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Aug 1, 2023
* log types table; details page with basic editing



* implemented create, delete of log type



* detection rules; delete modals added



* updated snapshots



* addressed PR comments



* updated cypress workflow



* updated detector cypress test



* addressed PR comments



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Aug 1, 2023
* log types table; details page with basic editing



* implemented create, delete of log type



* detection rules; delete modals added



* updated snapshots



* addressed PR comments



* updated cypress workflow



* updated detector cypress test



* addressed PR comments



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
) (opensearch-project#680)

* log types table; details page with basic editing



* implemented create, delete of log type



* detection rules; delete modals added



* updated snapshots



* addressed PR comments



* updated cypress workflow



* updated detector cypress test



* addressed PR comments



---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants