[Backport 2.9][Custom log types] CRUD operations for log types (#675) #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <[email protected]> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated snapshots Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.9 #680 +/- ##
==========================================
- Coverage 31.94% 31.37% -0.57%
==========================================
Files 146 151 +5
Lines 4639 4771 +132
Branches 760 781 +21
==========================================
+ Hits 1482 1497 +15
- Misses 2979 3096 +117
Partials 178 178 |
AWSHurneyt
approved these changes
Jul 31, 2023
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
) (opensearch-project#680) * log types table; details page with basic editing * implemented create, delete of log type * detection rules; delete modals added * updated snapshots * addressed PR comments * updated cypress workflow * updated detector cypress test * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #675 to 2.9
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.