addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>
opensearch-project · Jul 30, 2023 · 7b62402 · 7b62402
1 parent 3fbd526
commit 7b62402
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/public/pages/LogTypes/components/DeleteLogTypeModal.tsx b/public/pages/LogTypes/components/DeleteLogTypeModal.tsx
@@ -66,7 +66,9 @@ export const DeleteLogTypeModal: React.FC<DeleteLogTypeModalProps> = ({
           <EuiModalBody>
             <EuiCallOut
               size="s"
-              title={`This log type is associated with ${detectionRulesCount} detection rules.`}
+              title={`This log type is associated with ${detectionRulesCount} detection ${
+                detectionRulesCount > 1 ? 'rules' : 'rule'
+              }.`}
               iconType={'iInCircle'}
               color="warning"
             />

diff --git a/public/pages/LogTypes/components/LogTypeForm.tsx b/public/pages/LogTypes/components/LogTypeForm.tsx
@@ -83,7 +83,7 @@ export const LogTypeForm: React.FC<LogTypeFormProps> = ({
             setLogTypeDetails(newLogType);
             updateErrors(newLogType);
           }}
-          placeholder="Enter name for log type"
+          placeholder="Enter name for the log type"
           disabled={!isEditMode || !!logTypeDetails.detectionRules}
         />
       </EuiFormRow>

diff --git a/public/pages/LogTypes/containers/CreateLogType.tsx b/public/pages/LogTypes/containers/CreateLogType.tsx
@@ -40,7 +40,7 @@ export const CreateLogType: React.FC<CreateLogTypeProps> = ({ history, notificat
       subTitleText={
         <p>
           Create log type to categorize and identify detection rules for your data sources. &nbsp;{' '}
-          <EuiLink href={'www.bing.com'} target="_blank">
+          <EuiLink href={'#'} target="_blank">
             Learn more
           </EuiLink>
         </p>