-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule details flyout on create rule page #236
Merged
amsiglan
merged 4 commits into
opensearch-project:main
from
djindjic:feature/212-rule-details-flyout-on-create-rule-page
Dec 20, 2022
Merged
Rule details flyout on create rule page #236
amsiglan
merged 4 commits into
opensearch-project:main
from
djindjic:feature/212-rule-details-flyout-on-create-rule-page
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Djindjic <[email protected]>
Screen.Recording.2022-12-17.at.10.16.44.AM.mov |
amsiglan
reviewed
Dec 19, 2022
public/pages/Rules/components/RuleViewerFlyout/RuleViewerFlyout.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Aleksandar Djindjic <[email protected]>
…flyout-on-create-rule-page
…flyout-on-create-rule-page
amsiglan
approved these changes
Dec 20, 2022
sbcd90
approved these changes
Dec 20, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
* rule details flyout on create rule page Signed-off-by: Aleksandar Djindjic <[email protected]> * do not block deletetion if no notifications Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 547cbd3)
amsiglan
pushed a commit
that referenced
this pull request
Dec 21, 2022
* rule details flyout on create rule page Signed-off-by: Aleksandar Djindjic <[email protected]> * do not block deletetion if no notifications Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 547cbd3) Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…nsearch-project#246) * rule details flyout on create rule page Signed-off-by: Aleksandar Djindjic <[email protected]> * do not block deletetion if no notifications Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 547cbd3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…nsearch-project#246) * rule details flyout on create rule page Signed-off-by: Aleksandar Djindjic <[email protected]> * do not block deletetion if no notifications Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 547cbd3) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show flyout rule details by clicking on rule name
Issues Resolved
Closes #212
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.