Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule details flyout on create rule page #236

Conversation

djindjic
Copy link
Contributor

Description

Show flyout rule details by clicking on rule name

Issues Resolved

Closes #212

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic requested a review from a team December 17, 2022 09:16
@djindjic
Copy link
Contributor Author

djindjic commented Dec 17, 2022

@amsiglan

Screen.Recording.2022-12-17.at.10.16.44.AM.mov

@amsiglan amsiglan merged commit 547cbd3 into opensearch-project:main Dec 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
* rule details flyout on create rule page

Signed-off-by: Aleksandar Djindjic <[email protected]>

* do not block deletetion if no notifications

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 547cbd3)
amsiglan pushed a commit that referenced this pull request Dec 21, 2022
* rule details flyout on create rule page

Signed-off-by: Aleksandar Djindjic <[email protected]>

* do not block deletetion if no notifications

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 547cbd3)

Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Feb 22, 2023
…nsearch-project#246)

* rule details flyout on create rule page

Signed-off-by: Aleksandar Djindjic <[email protected]>

* do not block deletetion if no notifications

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 547cbd3)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…nsearch-project#246)

* rule details flyout on create rule page

Signed-off-by: Aleksandar Djindjic <[email protected]>

* do not block deletetion if no notifications

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit 547cbd3)

Co-authored-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clicking on a rule should open a flyout in Create detector
3 participants