Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clicking on a rule should open a flyout in Create detector #212

Closed
kamingleung opened this issue Dec 12, 2022 · 3 comments · Fixed by #236
Closed

[BUG] Clicking on a rule should open a flyout in Create detector #212

kamingleung opened this issue Dec 12, 2022 · 3 comments · Fixed by #236
Labels
bug Something isn't working

Comments

@kamingleung
Copy link

What is the bug?
in the Create detector flow, when a user clicks on a rule in Step 1, it should open a flyout with the rule details. This flyout should contain the same rule information and as the rule flyout in the Rule editor.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to 'Create detector'
  2. On Step 1: Define detector, open "Detection rules"
  3. Click on any rule links
  4. The links are currently not doing anything

What is the expected behavior?
When a user clicks on a rule link, it should open a flyout on the same page. The flyout should contain the rule details.

Do you have any mockups?
image

@djindjic
Copy link
Contributor

@kamingleung here is how it looks in my local at the moment while its in peer review

Screen.Recording.2022-12-17.at.10.16.44.AM.mov

Repository owner moved this from Ready to work on to Done in Security analytics dashboards 2.5 release Dec 20, 2022
@kamingleung
Copy link
Author

@djindjic Follow-up question: On step 4 of the create flow, does clicking a rule name also open a flyout with rule details? If not, we can create a new issue for that.

image

@djindjic
Copy link
Contributor

Good point @kamingleung, it doesn't open flyout on page 4.
Also it could be added to edit detector page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants