Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clicking on a rule should open a flyout in View and Edit detector flows #280

Closed
kamingleung opened this issue Dec 30, 2022 · 2 comments · Fixed by #292
Closed

[BUG] Clicking on a rule should open a flyout in View and Edit detector flows #280

kamingleung opened this issue Dec 30, 2022 · 2 comments · Fixed by #292
Labels
bug Something isn't working

Comments

@kamingleung
Copy link

What is the bug?
On the View detector page, when a user clicks on a rule, it should open a flyout with the rule details. This flyout should contain the same rule information and as the rule flyout in the Rule editor. Similar to #212

How can one reproduce the bug?
Steps to reproduce the behavior:
For View detector page:

  1. Go to 'Detectors'
  2. Click on any existing detectors
  3. Under 'Detector rules'
  4. Click on any rule links
  5. The links are not doing anything

image

For edit detector rules page:

  1. From the same page above, click on 'Edit detector rules'
  2. Click on any rule links
  3. The links are not doing anything
    image

What is the expected behavior?
When a user clicks on a rule link, it should open a flyout on the same page. The flyout should contain the rule details.

@djindjic
Copy link
Contributor

djindjic commented Jan 9, 2023

@kamingleung @amsiglan

  1. edit detector rules page is already done in this PR Rule details flyout on create rule page #236 (that's the same component shared on create detector flow)
  2. I will add support for rule details flyout on detector page view mode

@djindjic
Copy link
Contributor

In order to fix missing detection yaml data in context of this PR we have also migrate rules fetching to RulesViewModelActor on:

  1. Create detector flow 1st and 4th step
  2. Detector view page
  3. Update detector rules

See PR for more details and recordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants