Rule details flyout on detector view page #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Djindjic <[email protected]>
Screen.Recording.2023-01-09.at.9.07.28.PM.mov |
paladin-tech
approved these changes
Jan 9, 2023
jovancacvetkovic
approved these changes
Jan 9, 2023
amsiglan
approved these changes
Jan 10, 2023
…flyout-on-detector-view-page
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt
approved these changes
Jan 10, 2023
Signed-off-by: Aleksandar Djindjic <[email protected]>
djindjic
force-pushed
the
feature/280-rule-details-flyout-on-detector-view-page
branch
from
2bd1eb8 to
60af9ab
Compare
Signed-off-by: Aleksandar Djindjic <[email protected]>
|
@amsiglan here is recording on pages that are migrated to Screen.Recording.2023-01-10.at.7.10.51.PM.mov |
|
@amsiglan since I've enhanced Screen.Recording.2023-01-10.at.7.15.34.PM.mov |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
* Rule details flyout on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * use RulesViewModelActor on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate create detector to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate update detector rules to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * fix create detector 4th step Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2ef2d67)
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 10, 2023
* Rule details flyout on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * use RulesViewModelActor on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate create detector to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate update detector rules to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * fix create detector 4th step Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2ef2d67) Co-authored-by: Aleksandar Djindjic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Feb 22, 2023
…pensearch-project#315) * Rule details flyout on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * use RulesViewModelActor on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate create detector to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate update detector rules to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * fix create detector 4th step Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2ef2d67) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#315) * Rule details flyout on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * use RulesViewModelActor on detector view page Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate create detector to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * migrate update detector rules to RulesViewModelActor Signed-off-by: Aleksandar Djindjic <[email protected]> * fix create detector 4th step Signed-off-by: Aleksandar Djindjic <[email protected]> Signed-off-by: Aleksandar Djindjic <[email protected]> (cherry picked from commit 2ef2d67) Co-authored-by: Aleksandar Djindjic <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show rule details on detector view page
Description
in context of this PR we have also migrate rules fetching to
RulesViewModelActoron:Issues Resolved
Closes #280
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.